ALSA: ua101, usx2y: fix broken MIDI output (e99ddfde) · Commits · 戴 / test

Commit (ALSA: usbaudio: implement USB autosuspend) added autosuspend code to all files making up the snd-usb-audio driver. However, midi.c is part of snd-usb-lib and is also used by other drivers, not all of which support autosuspend. Thus, calls to usb_autopm_get_interface() could fail, and this unexpected error would result in the MIDI output being completely unusable. Make it work by ignoring the error that is expected with drivers that do not support autosuspend. Reported-by:

Colin Fletcher <colin.m.fletcher@googlemail.com> Reported-by:

Devin Venable <venable.devin@gmail.com> Reported-by:

Dr Nick Bailey <nicholas.bailey@glasgow.ac.uk> Reported-by:

Jannis Achstetter <jannis_achstetter@web.de> Reported-by:

Rui Nuno Capela <rncbc@rncbc.org> Cc: Oliver Neukum <oliver@neukum.org> Cc: 2.6.39+ <stable@vger.kernel.org> Signed-off-by:

Clemens Ladisch <clemens@ladisch.de>

sound/usb/midi.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -148,6 +148,7 @@ struct snd_usb_midi_out_endpoint {
		struct snd_usb_midi_out_endpoint* ep;
		struct snd_rawmidi_substream *substream;
		int active;
		bool autopm_reference;
		uint8_t cable; /* cable number << 4 */
		uint8_t state;
		#define STATE_UNKNOWN 0
		@@ -1076,7 +1077,8 @@ static int snd_usbmidi_output_open(struct snd_rawmidi_substream *substream)
		return -ENXIO;
		}
		err = usb_autopm_get_interface(umidi->iface);
		if (err < 0)
		port->autopm_reference = err >= 0;
		if (err < 0 && err != -EACCES)
		return -EIO;
		substream->runtime->private_data = port;
		port->state = STATE_UNKNOWN;
		@@ -1087,8 +1089,10 @@ static int snd_usbmidi_output_open(struct snd_rawmidi_substream *substream)
		static int snd_usbmidi_output_close(struct snd_rawmidi_substream *substream)
		{
		struct snd_usb_midi* umidi = substream->rmidi->private_data;
		struct usbmidi_out_port *port = substream->runtime->private_data;

		substream_open(substream, 0);
		if (port->autopm_reference)
		usb_autopm_put_interface(umidi->iface);
		return 0;
		}

Admin message