net: hns3: replace disable_irq by IRQ_NOAUTOEN flag (e99a308d) · Commits · 戴 / test

disable_irq() after request_irq() is still risk as there is a chance irq can come after request_irq() and before disable_irq(). this should be done by IRQ_NOAUTOEN flag. Signed-off-by:

Barry Song <song.bao.hua@hisilicon.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -8,6 +8,7 @@
		#include <linux/cpu_rmap.h>
		#endif
		#include <linux/if_vlan.h>
		#include <linux/irq.h>
		#include <linux/ip.h>
		#include <linux/ipv6.h>
		#include <linux/module.h>
		@@ -154,6 +155,7 @@ static int hns3_nic_init_irq(struct hns3_nic_priv *priv)

		tqp_vectors->name[HNAE3_INT_NAME_LEN - 1] = '\0';

		irq_set_status_flags(tqp_vectors->vector_irq, IRQ_NOAUTOEN);
		ret = request_irq(tqp_vectors->vector_irq, hns3_irq_handle, 0,
		tqp_vectors->name, tqp_vectors);
		if (ret) {
		@@ -163,8 +165,6 @@ static int hns3_nic_init_irq(struct hns3_nic_priv *priv)
		return ret;
		}

		disable_irq(tqp_vectors->vector_irq);

		irq_set_affinity_hint(tqp_vectors->vector_irq,
		&tqp_vectors->affinity_mask);

Admin message