Commit e9868505 authored Dec 11, 2012 by Rik van Riel Committed by Linus Torvalds Dec 11, 2012

mm,vmscan: only evict file pages when we have plenty



If we have more inactive file pages than active file pages, we skip
scanning the active file pages altogether, with the idea that we do not
want to evict the working set when there is plenty of streaming IO in the
cache.

However, the code forgot to also skip scanning anonymous pages in that
situation.  That leads to the curious situation of keeping the active file
pages protected from being paged out when there are lots of inactive file
pages, while still scanning and evicting anonymous pages.

This patch fixes that situation, by only evicting file pages when we have
plenty of them and most are inactive.

[akpm@linux-foundation.org: adjust comment layout]
Signed-off-by: Rik van Riel <riel@redhat.com>
Cc: Mel Gorman <mel@csn.ul.ie>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent e749eb95

mm/vmscan.c

+13 −2

Original line number	Diff line number	Diff line
		@@ -1679,13 +1679,24 @@ static void get_scan_count(struct lruvec lruvec, struct scan_control sc,

		if (global_reclaim(sc)) {
		free = zone_page_state(zone, NR_FREE_PAGES);
		/* If we have very few page cache pages,
		force-scan anon pages. */
		if (unlikely(file + free <= high_wmark_pages(zone))) {
		/*
		* If we have very few page cache pages, force-scan
		* anon pages.
		*/
		fraction[0] = 1;
		fraction[1] = 0;
		denominator = 1;
		goto out;
		} else if (!inactive_file_is_low_global(zone)) {
		/*
		* There is enough inactive page cache, do not
		* reclaim anything from the working set right now.
		*/
		fraction[0] = 0;
		fraction[1] = 1;
		denominator = 1;
		goto out;
		}
		}

Admin message