ionic: add lif_quiesce to wait for queue activity to stop (e982ae6a) · Commits · 戴 / test

Even though we've already turned off the queue activity with the ionic_qcq_disable(), we need to wait for any device queues that are processing packets to drain down before we try to flush our packets and tear down the queues. Signed-off-by:

Shannon Nelson <snelson@pensando.io> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/pensando/ionic/ionic_lif.c

+16 −0

Original line number	Diff line number	Diff line
		@@ -242,6 +242,21 @@ static int ionic_qcq_disable(struct ionic_qcq *qcq)
		return ionic_adminq_post_wait(lif, &ctx);
		}

		static void ionic_lif_quiesce(struct ionic_lif *lif)
		{
		struct ionic_admin_ctx ctx = {
		.work = COMPLETION_INITIALIZER_ONSTACK(ctx.work),
		.cmd.lif_setattr = {
		.opcode = IONIC_CMD_LIF_SETATTR,
		.attr = IONIC_LIF_ATTR_STATE,
		.index = lif->index,
		.state = IONIC_LIF_DISABLE
		},
		};

		ionic_adminq_post_wait(lif, &ctx);
		}

		static void ionic_lif_qcq_deinit(struct ionic_lif lif, struct ionic_qcq qcq)
		{
		struct ionic_dev *idev = &lif->ionic->idev;
		@@ -1589,6 +1604,7 @@ int ionic_stop(struct net_device *netdev)
		netif_tx_disable(netdev);

		ionic_txrx_disable(lif);
		ionic_lif_quiesce(lif);
		ionic_txrx_deinit(lif);
		ionic_txrx_free(lif);

Admin message