Commit e9814295 authored Aug 05, 2014 by Axel Lin Committed by Guenter Roeck Aug 05, 2014

hwmon: (ads1015) Fix out-of-bounds array access



Current code uses data_rate as array index in ads1015_read_adc() and uses pga
as array index in ads1015_reg_to_mv, so we must make sure both data_rate and
pga settings are in valid value range.
Return -EINVAL if the setting is out-of-range.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent 5b963089

drivers/hwmon/ads1015.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -212,6 +212,7 @@ static int ads1015_get_channels_config_of(struct i2c_client *client)
		dev_err(&client->dev,
		"invalid gain on %s\n",
		node->full_name);
		return -EINVAL;
		}
		}

		@@ -222,6 +223,7 @@ static int ads1015_get_channels_config_of(struct i2c_client *client)
		dev_err(&client->dev,
		"invalid data_rate on %s\n",
		node->full_name);
		return -EINVAL;
		}
		}

Admin message