Commit e96f0bf2 authored by Aneesh Kumar K.V's avatar Aneesh Kumar K.V Committed by Dan Williams
Browse files

libnvdimm/pfn_dev: Add a build check to make sure we notice when struct page size change 



Namespaces created with PFN_MODE_PMEM mode stores struct page in the reserve
block area. We need to make sure we account for the right struct page
size while doing this. Instead of directly depending on sizeof(struct page)
which can change based on different kernel config option, use the max struct
page size (64) while calculating the reserve block area. This makes sure pmem
device can be used across kernels built with different configs.

If the above assumption of max struct page size change, we need to update the
reserve block allocation space for new namespaces created.

Signed-off-by: default avatarAneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Link: https://lore.kernel.org/r/20190905154603.10349-4-aneesh.kumar@linux.ibm.com


Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent 1c97afa7

drivers/nvdimm/nd.h

+4 −0
Original line number Diff line number Diff line
@@ -375,6 +375,10 @@ unsigned int pmem_sector_size(struct nd_namespace_common *ndns); 
void nvdimm_badblocks_populate(struct nd_region *nd_region,

		struct badblocks *bb, const struct resource *res);

#if IS_ENABLED(CONFIG_ND_CLAIM)



/* max struct page size independent of kernel config */

#define MAX_STRUCT_PAGE_SIZE 64



int nvdimm_setup_pfn(struct nd_pfn *nd_pfn, struct dev_pagemap *pgmap);

int devm_nsio_enable(struct device *dev, struct nd_namespace_io *nsio);

void devm_nsio_disable(struct device *dev, struct nd_namespace_io *nsio);

drivers/nvdimm/pfn_devs.c

+9 −1
Original line number Diff line number Diff line
@@ -701,8 +701,16 @@ static int nd_pfn_init(struct nd_pfn *nd_pfn) 
		 * The altmap should be padded out to the block size used

		 * when populating the vmemmap. This *should* be equal to

		 * PMD_SIZE for most architectures.

		 *

		 * Also make sure size of struct page is less than 64. We

		 * want to make sure we use large enough size here so that

		 * we don't have a dynamic reserve space depending on

		 * struct page size. But we also want to make sure we notice

		 * when we end up adding new elements to struct page.

		 */

		offset = ALIGN(start + SZ_8K + 64 * npfns, align) - start;

		BUILD_BUG_ON(sizeof(struct page) > MAX_STRUCT_PAGE_SIZE);

		offset = ALIGN(start + SZ_8K + MAX_STRUCT_PAGE_SIZE * npfns, align)

			- start;

	} else if (nd_pfn->mode == PFN_MODE_RAM)

		offset = ALIGN(start + SZ_8K, align) - start;

	else

CRA Git | Maintained and supported by SUSTech CRA and CCSE