parport: do not check portlist when using device-model (e962cd9c) · Commits · 戴 / test

We do not need to maintain a list of ports when we are using the device-model. The base layer is going to maintain the list for us and we can get the list of ports just using bus_for_each_dev(). Signed-off-by:

Sudip Mukherjee <sudipm.mukherjee@gmail.com> Link: https://lore.kernel.org/r/20191016144540.18810-2-sudipm.mukherjee@gmail.com Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/parport/share.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -266,9 +266,6 @@ static int port_check(struct device dev, void dev_drv)
		int __parport_register_driver(struct parport_driver drv, struct module owner,
		const char *mod_name)
		{
		if (list_empty(&portlist))
		get_lowlevel_driver();

		if (drv->devmodel) {
		/* using device model */
		int ret;
		@@ -292,6 +289,8 @@ int __parport_register_driver(struct parport_driver drv, struct module owner,

		drv->devmodel = false;

		if (list_empty(&portlist))
		get_lowlevel_driver();
		mutex_lock(&registration_lock);
		list_for_each_entry(port, &portlist, list)
		drv->attach(port);

Admin message