Commit e955537e authored by Bob Peterson's avatar Bob Peterson Committed by Andreas Gruenbacher
Browse files

gfs2: eliminate tr_num_revoke_rm 



For its journal processing, gfs2 kept track of the number of buffers
added and removed on a per-transaction basis. These values are used
to calculate space needed in the journal. But while these calculations
make sense for the number of buffers, they make no sense for revokes.
Revokes are managed in their own list, linked from the superblock.
So it's entirely unnecessary to keep separate per-transaction counts
for revokes added and removed. A single count will do the same job.
Therefore, this patch combines the transaction revokes into a single
count.

Signed-off-by: default avatarBob Peterson <rpeterso@redhat.com>
Signed-off-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
parent 5b3a9f34

fs/gfs2/incore.h

+0 −1
Original line number Diff line number Diff line
@@ -504,7 +504,6 @@ struct gfs2_trans { 
	unsigned int tr_num_buf_rm;

	unsigned int tr_num_databuf_rm;

	unsigned int tr_num_revoke;

	unsigned int tr_num_revoke_rm;



	struct list_head tr_list;

	struct list_head tr_databuf;

fs/gfs2/log.c

+1 −2
Original line number Diff line number Diff line
@@ -882,7 +882,6 @@ static void gfs2_merge_trans(struct gfs2_trans *old, struct gfs2_trans *new) 
	old->tr_num_buf_rm	+= new->tr_num_buf_rm;

	old->tr_num_databuf_rm	+= new->tr_num_databuf_rm;

	old->tr_num_revoke	+= new->tr_num_revoke;

	old->tr_num_revoke_rm	+= new->tr_num_revoke_rm;



	list_splice_tail_init(&new->tr_databuf, &old->tr_databuf);

	list_splice_tail_init(&new->tr_buf, &old->tr_buf);
@@ -904,7 +903,7 @@ static void log_refund(struct gfs2_sbd *sdp, struct gfs2_trans *tr) 
		set_bit(TR_ATTACHED, &tr->tr_flags);

	}



	sdp->sd_log_commited_revoke += tr->tr_num_revoke - tr->tr_num_revoke_rm;

	sdp->sd_log_commited_revoke += tr->tr_num_revoke;

	reserved = calc_reserved(sdp);

	maxres = sdp->sd_log_blks_reserved + tr->tr_reserved;

	gfs2_assert_withdraw(sdp, maxres >= reserved);

fs/gfs2/trans.c

+3 −3
Original line number Diff line number Diff line
@@ -77,10 +77,10 @@ static void gfs2_print_trans(struct gfs2_sbd *sdp, const struct gfs2_trans *tr) 
	fs_warn(sdp, "blocks=%u revokes=%u reserved=%u touched=%u\n",

		tr->tr_blocks, tr->tr_revokes, tr->tr_reserved,

		test_bit(TR_TOUCHED, &tr->tr_flags));

	fs_warn(sdp, "Buf %u/%u Databuf %u/%u Revoke %u/%u\n",

	fs_warn(sdp, "Buf %u/%u Databuf %u/%u Revoke %u\n",

		tr->tr_num_buf_new, tr->tr_num_buf_rm,

		tr->tr_num_databuf_new, tr->tr_num_databuf_rm,

		tr->tr_num_revoke, tr->tr_num_revoke_rm);

		tr->tr_num_revoke);

}



void gfs2_trans_end(struct gfs2_sbd *sdp)
@@ -263,7 +263,7 @@ void gfs2_trans_remove_revoke(struct gfs2_sbd *sdp, u64 blkno, unsigned int len) 
			gfs2_assert_withdraw(sdp, sdp->sd_log_num_revoke);

			sdp->sd_log_num_revoke--;

			kmem_cache_free(gfs2_bufdata_cachep, bd);

			tr->tr_num_revoke_rm++;

			tr->tr_num_revoke--;

			if (--n == 0)

				break;

		}

CRA Git | Maintained and supported by SUSTech CRA and CCSE