Commit e93fb3e9 authored by John Fastabend's avatar John Fastabend Committed by David S. Miller
Browse files

net: route dump netlink NLM_F_MULTI flag missing 

An excerpt from netlink(7) man page,

  In multipart messages (multiple nlmsghdr headers with associated payload
  in one byte stream) the first and all following headers have the
  NLM_F_MULTI flag set, except for the last  header  which  has the type
  NLMSG_DONE.

but, after (ee28906f) there is a missing NLM_F_MULTI flag in the middle of a
FIB dump. The result is user space applications following above man page
excerpt may get confused and may stop parsing msg believing something went
wrong.

In the golang netlink lib [0] the library logic stops parsing believing the
message is not a multipart message. Found this running Cilium[1] against
net-next while adding a feature to auto-detect routes. I noticed with
multiple route tables we no longer could detect the default routes on net
tree kernels because the library logic was not returning them.

Fix this by handling the fib_dump_info_fnhe() case the same way the
fib_dump_info() handles it by passing the flags argument through the
call chain and adding a flags argument to rt_fill_info().

Tested with Cilium stack and auto-detection of routes works again. Also
annotated libs to dump netlink msgs and inspected NLM_F_MULTI and
NLMSG_DONE flags look correct after this.

Note: In inet_rtm_getroute() pass rt_fill_info() '0' for flags the same
as is done for fib_dump_info() so this looks correct to me.

[0] https://github.com/vishvananda/netlink/
[1] https://github.com/cilium/



Fixes: ee28906f ("ipv4: Dump route exceptions if requested")
Signed-off-by: default avatarJohn Fastabend <john.fastabend@gmail.com>
Reviewed-by: default avatarStefano Brivio <sbrivio@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 292a50e3

include/net/route.h

+1 −1
Original line number Diff line number Diff line
@@ -233,7 +233,7 @@ void rt_del_uncached_list(struct rtable *rt); 


int fib_dump_info_fnhe(struct sk_buff *skb, struct netlink_callback *cb,

		       u32 table_id, struct fib_info *fi,

		       int *fa_index, int fa_start);

		       int *fa_index, int fa_start, unsigned int flags);



static inline void ip_rt_put(struct rtable *rt)

{

net/ipv4/fib_trie.c

+1 −1
Original line number Diff line number Diff line
@@ -2145,7 +2145,7 @@ static int fn_trie_dump_leaf(struct key_vector *l, struct fib_table *tb, 


		if (filter->dump_exceptions) {

			err = fib_dump_info_fnhe(skb, cb, tb->tb_id, fi,

						 &i_fa, s_fa);

						 &i_fa, s_fa, flags);

			if (err < 0)

				goto stop;

		}

net/ipv4/route.c

+10 −7
Original line number Diff line number Diff line
@@ -2728,7 +2728,8 @@ EXPORT_SYMBOL_GPL(ip_route_output_flow); 
/* called with rcu_read_lock held */

static int rt_fill_info(struct net *net, __be32 dst, __be32 src,

			struct rtable *rt, u32 table_id, struct flowi4 *fl4,

			struct sk_buff *skb, u32 portid, u32 seq)

			struct sk_buff *skb, u32 portid, u32 seq,

			unsigned int flags)

{

	struct rtmsg *r;

	struct nlmsghdr *nlh;
@@ -2736,7 +2737,7 @@ static int rt_fill_info(struct net *net, __be32 dst, __be32 src, 
	u32 error;

	u32 metrics[RTAX_MAX];



	nlh = nlmsg_put(skb, portid, seq, RTM_NEWROUTE, sizeof(*r), 0);

	nlh = nlmsg_put(skb, portid, seq, RTM_NEWROUTE, sizeof(*r), flags);

	if (!nlh)

		return -EMSGSIZE;
@@ -2860,7 +2861,7 @@ nla_put_failure: 
static int fnhe_dump_bucket(struct net *net, struct sk_buff *skb,

			    struct netlink_callback *cb, u32 table_id,

			    struct fnhe_hash_bucket *bucket, int genid,

			    int *fa_index, int fa_start)

			    int *fa_index, int fa_start, unsigned int flags)

{

	int i;
@@ -2891,7 +2892,7 @@ static int fnhe_dump_bucket(struct net *net, struct sk_buff *skb, 
			err = rt_fill_info(net, fnhe->fnhe_daddr, 0, rt,

					   table_id, NULL, skb,

					   NETLINK_CB(cb->skb).portid,

					   cb->nlh->nlmsg_seq);

					   cb->nlh->nlmsg_seq, flags);

			if (err)

				return err;

next:
@@ -2904,7 +2905,7 @@ next: 


int fib_dump_info_fnhe(struct sk_buff *skb, struct netlink_callback *cb,

		       u32 table_id, struct fib_info *fi,

		       int *fa_index, int fa_start)

		       int *fa_index, int fa_start, unsigned int flags)

{

	struct net *net = sock_net(cb->skb->sk);

	int nhsel, genid = fnhe_genid(net);
@@ -2922,7 +2923,8 @@ int fib_dump_info_fnhe(struct sk_buff *skb, struct netlink_callback *cb, 
		err = 0;

		if (bucket)

			err = fnhe_dump_bucket(net, skb, cb, table_id, bucket,

					       genid, fa_index, fa_start);

					       genid, fa_index, fa_start,

					       flags);

		rcu_read_unlock();

		if (err)

			return err;
@@ -3183,7 +3185,8 @@ static int inet_rtm_getroute(struct sk_buff *in_skb, struct nlmsghdr *nlh, 
				    fl4.flowi4_tos, res.fi, 0);

	} else {

		err = rt_fill_info(net, dst, src, rt, table_id, &fl4, skb,

				   NETLINK_CB(in_skb).portid, nlh->nlmsg_seq);

				   NETLINK_CB(in_skb).portid,

				   nlh->nlmsg_seq, 0);

	}

	if (err < 0)

		goto errout_rcu;

CRA Git | Maintained and supported by SUSTech CRA and CCSE