Commit e91b6006 authored Nov 06, 2016 by Markus Elfring Committed by Mauro Carvalho Chehab Nov 16, 2016

[media] DaVinci-VPFE-Capture: Replace a memcpy() call by an assignment in vpfe_enum_input()



Use a direct assignment for an array element which can be set over the
pointer variable "inp" instead of calling the function "memcpy" here.

Suggested-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

parent 2eaa68f3

drivers/media/platform/davinci/vpfe_capture.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1086,7 +1086,7 @@ static int vpfe_enum_input(struct file file, void priv,
		return -EINVAL;
		}
		sdinfo = &vpfe_dev->cfg->sub_devs[subdev];
		memcpy(inp, &sdinfo->inputs[index], sizeof(struct v4l2_input));
		*inp = sdinfo->inputs[index];
		return 0;
		}

Admin message