Unverified Commit e9157a44 authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: SOF: loader: fix memory leak in get_ext_windows 



sdev->info_window is allocated with kmemdup and never freed, use devm_
version since this is only used for first boot.

Fixes: 8d809c15 ('ASoC: SOF: ext_manifest: parse windows')
Cc: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarDaniel Baluta <daniel.baluta@gmail.com>
Reviewed-by: default avatarKai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: default avatarRander Wang <rander.wang@linux.intel.com>
Reviewed-by: default avatarGuennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Signed-off-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/20200825235854.1588034-3-ranjani.sridharan@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 76ab546c

sound/soc/sof/loader.c

+2 −1
Original line number Diff line number Diff line
@@ -33,7 +33,8 @@ static int get_ext_windows(struct snd_sof_dev *sdev, 
	}



	/* keep a local copy of the data */

	sdev->info_window = kmemdup(w, ext_hdr->hdr.size, GFP_KERNEL);

	sdev->info_window = devm_kmemdup(sdev->dev, w, ext_hdr->hdr.size,

					 GFP_KERNEL);

	if (!sdev->info_window)

		return -ENOMEM;

CRA Git | Maintained and supported by SUSTech CRA and CCSE