Commit e8fdde10 authored Jul 31, 2013 by Viresh Kumar Committed by Rafael J. Wysocki Aug 07, 2013

cpufreq: Remove extra variables from cpufreq_add_dev_symlink()



We call cpufreq_cpu_get() in cpufreq_add_dev_symlink() to increase usage
refcount of policy, but not to get a policy for the given CPU.  So, we
don't really need to capture the return value of this routine.  We can
simply use policy passed as an argument to cpufreq_add_dev_symlink().

Moreover debug print is rewritten to make it more clear.

[rjw: Changelog]
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 5302c3fb

drivers/cpufreq/cpufreq.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -813,19 +813,18 @@ static int cpufreq_add_dev_symlink(unsigned int cpu,
		int ret = 0;

		for_each_cpu(j, policy->cpus) {
		struct cpufreq_policy *managed_policy;
		struct device *cpu_dev;

		if (j == cpu)
		continue;

		pr_debug("CPU %u already managed, adding link\n", j);
		managed_policy = cpufreq_cpu_get(cpu);
		pr_debug("Adding link for CPU: %u\n", j);
		cpufreq_cpu_get(cpu);
		cpu_dev = get_cpu_device(j);
		ret = sysfs_create_link(&cpu_dev->kobj, &policy->kobj,
		"cpufreq");
		if (ret) {
		cpufreq_cpu_put(managed_policy);
		cpufreq_cpu_put(policy);
		return ret;
		}
		}

Admin message