Commit e8fd41bb authored May 02, 2019 by Maxim Levitsky Committed by Christoph Hellwig May 13, 2019

nvme-pci: init shadow doorbell after each reset



The spec states:

  "The settings are not retained across a Controller Level Reset"

Therefore the driver must enable the shadow doorbell, after each reset.

This was caught while testing the nvme driver over upcoming nvme-mdev
device.

Signed-off-by: Maxim Levitsky <mlevitsk@redhat.com>
Reviewed-by: Keith Busch <keith.busch@intel.com>
Reviewed-by: Minwoo Im <minwoo.im@samsung.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent 936b33f7

drivers/nvme/host/pci.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -2280,8 +2280,6 @@ static int nvme_dev_add(struct nvme_dev *dev)
		return ret;
		}
		dev->ctrl.tagset = &dev->tagset;

		nvme_dbbuf_set(dev);
		} else {
		blk_mq_update_nr_hw_queues(&dev->tagset, dev->online_queues - 1);

		@@ -2289,6 +2287,7 @@ static int nvme_dev_add(struct nvme_dev *dev)
		nvme_free_queues(dev, dev->online_queues);
		}

		nvme_dbbuf_set(dev);
		return 0;
		}

Admin message