drm/i915: don't mix bitwise and logical operations for has_snoop (e8fcdf1e) · Commits · 戴 / test

Also make the code more readable. Reviewed-by:

drivers/gpu/drm/i915/i915_dma.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -954,9 +954,11 @@ static void intel_device_info_runtime_init(struct drm_device *dev)
		else if (INTEL_INFO(dev)->gen >= 9)
		gen9_sseu_info_init(dev);

		/* Snooping is broken on BXT A stepping. */
		info->has_snoop = !info->has_llc;
		info->has_snoop &= !IS_BXT_REVID(dev, 0, BXT_REVID_A1);

		/* Snooping is broken on BXT A stepping. */
		if (IS_BXT_REVID(dev, 0, BXT_REVID_A1))
		info->has_snoop = false;

		DRM_DEBUG_DRIVER("slice total: %u\n", info->slice_total);
		DRM_DEBUG_DRIVER("subslice total: %u\n", info->subslice_total);