Commit e8f8d50e authored Apr 06, 2017 by Hannes Reinecke Committed by Martin K. Petersen Apr 06, 2017

scsi: sd: Return SUCCESS in sd_eh_action() after device offline



If sd_eh_action() decides to take the device offline there is
no point in returning FAILED, as taking the device offline
is the ultimate step in SCSI EH anyway.
So further escalation via SCSI EH is not likely to make a
difference and we can as well return SUCCESS.

Cc: Benjamin Block <bblock@linux.vnet.ibm.com>
Signed-off-by: Hannes Reinecke <hare@suse.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 7a38dc0b

drivers/scsi/sd.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1751,7 +1751,7 @@ static int sd_eh_action(struct scsi_cmnd *scmd, int eh_disp)
		"Medium access timeout failure. Offlining disk!\n");
		scsi_device_set_state(scmd->device, SDEV_OFFLINE);

		return FAILED;
		return SUCCESS;
		}

		return eh_disp;

Admin message