Commit e8f29bb7 authored Sep 28, 2016 by Felipe Balbi

usb: gadget: composite: correctly initialize ep->maxpacket



usb_endpoint_maxp() returns wMaxPacketSize in its
raw form. Without taking into consideration that it
also contains other bits reserved for isochronous
endpoints.

This patch fixes one occasion where this is a
problem by making sure that we initialize
ep->maxpacket only with lower 10 bits of the value
returned by usb_endpoint_maxp(). Note that seperate
patches will be necessary to audit all call sites of
usb_endpoint_maxp() and make sure that
usb_endpoint_maxp() only returns lower 10 bits of
wMaxPacketSize.

Cc: <stable@vger.kernel.org>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

parent 541b6fe6

drivers/usb/gadget/composite.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -197,7 +197,7 @@ int config_ep_by_speed(struct usb_gadget *g,

		ep_found:
		/* commit results */
		_ep->maxpacket = usb_endpoint_maxp(chosen_desc);
		_ep->maxpacket = usb_endpoint_maxp(chosen_desc) & 0x7ff;
		_ep->desc = chosen_desc;
		_ep->comp_desc = NULL;
		_ep->maxburst = 0;

Admin message