Commit e8f19746 authored Dec 16, 2016 by Colin Ian King Committed by Richard Weinberger Jan 17, 2017

ubifs: ensure zero err is returned on successful return



err is no longer being set on a successful return path, causing
a garbage value being returned. Fix this by setting err to zero
for the successful return path.

Found with static analysis by CoverityScan, CID 1389473

Fixes: 7799953b ("ubifs: Implement encrypt/decrypt for all IO")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Richard Weinberger <richard@nod.at>

parent 5cf7a0f3

fs/ubifs/journal.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1319,6 +1319,7 @@ static int truncate_data_node(const struct ubifs_info c, const struct inode in
		dn->compr_type = cpu_to_le16(compr_type);
		dn->size = cpu_to_le32(*new_len);
		*new_len = UBIFS_DATA_NODE_SZ + out_len;
		err = 0;
		out:
		kfree(buf);
		return err;

Admin message