Commit e8ee6c8c authored Jul 31, 2020 by Serge Semin Committed by Vinod Koul Aug 17, 2020

dmaengine: dw: Add DMA-channels mask cell support

DW DMA IP-core provides a way to synthesize the DMA controller with
channels having different parameters like maximum burst-length,
multi-block support, maximum data width, etc. Those parameters both
explicitly and implicitly affect the channels performance. Since DMA slave
devices might be very demanding to the DMA performance, let's provide a
functionality for the slaves to be assigned with DW DMA channels, which
performance according to the platform engineer fulfill their requirements.
After this patch is applied it can be done by passing the mask of suitable
DMA-channels either directly in the dw_dma_slave structure instance or as
a fifth cell of the DMA DT-property. If mask is zero or not provided, then
there is no limitation on the channels allocation.

For instance Baikal-T1 SoC is equipped with a DW DMAC engine, which first
two channels are synthesized with max burst length of 16, while the rest
of the channels have been created with max-burst-len=4. It would seem that
the first two channels must be faster than the others and should be more
preferable for the time-critical DMA slave devices. In practice it turned
out that the situation is quite the opposite. The channels with
max-burst-len=4 demonstrated a better performance than the channels with
max-burst-len=16 even when they both had been initialized with the same
settings. The performance drop of the first two DMA-channels made them
unsuitable for the DW APB SSI slave device. No matter what settings they
are configured with, full-duplex SPI transfers occasionally experience the
Rx FIFO overflow. It means that the DMA-engine doesn't keep up with
incoming data pace even though the SPI-bus is enabled with speed of 25MHz
while the DW DMA controller is clocked with 50MHz signal. There is no such
problem has been noticed for the channels synthesized with
max-burst-len=4.

Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
Link: https://lore.kernel.org/r/20200731200826.9292-6-Sergey.Semin@baikalelectronics.ru

Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent 8d2f59da

drivers/dma/dw/core.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -772,6 +772,10 @@ bool dw_dma_filter(struct dma_chan chan, void param)
		if (dws->dma_dev != chan->device->dev)
		return false;

		/* permit channels in accordance with the channels mask */
		if (dws->channels && !(dws->channels & dwc->mask))
		return false;

		/* We have to copy data since dws can be temporary storage */
		memcpy(&dwc->dws, dws, sizeof(struct dw_dma_slave));

drivers/dma/dw/of.c

+5 −2

Original line number	Diff line number	Diff line
		@@ -22,18 +22,21 @@ static struct dma_chan dw_dma_of_xlate(struct of_phandle_args dma_spec,
		};
		dma_cap_mask_t cap;

		if (dma_spec->args_count != 3)
		if (dma_spec->args_count < 3 \|\| dma_spec->args_count > 4)
		return NULL;

		slave.src_id = dma_spec->args[0];
		slave.dst_id = dma_spec->args[0];
		slave.m_master = dma_spec->args[1];
		slave.p_master = dma_spec->args[2];
		if (dma_spec->args_count >= 4)
		slave.channels = dma_spec->args[3];

		if (WARN_ON(slave.src_id >= DW_DMA_MAX_NR_REQUESTS \|\|
		slave.dst_id >= DW_DMA_MAX_NR_REQUESTS \|\|
		slave.m_master >= dw->pdata->nr_masters \|\|
		slave.p_master >= dw->pdata->nr_masters))
		slave.p_master >= dw->pdata->nr_masters \|\|
		slave.channels >= BIT(dw->pdata->nr_channels)))
		return NULL;

		dma_cap_zero(cap);

include/linux/platform_data/dma-dw.h

+2 −0

Original line number	Diff line number	Diff line
		@@ -26,6 +26,7 @@ struct device;
		* @dst_id: dst request line
		* @m_master: memory master for transfers on allocated channel
		* @p_master: peripheral master for transfers on allocated channel
		* @channels: mask of the channels permitted for allocation (zero value means any)
		* @hs_polarity:set active low polarity of handshake interface
		*/
		struct dw_dma_slave {
		@@ -34,6 +35,7 @@ struct dw_dma_slave {
		u8 dst_id;
		u8 m_master;
		u8 p_master;
		u8 channels;
		bool hs_polarity;
		};

Admin message