Commit e8e5752d authored Dec 17, 2008 by Krzysztof Halasa Committed by David S. Miller Dec 17, 2008

net: kernel BUG at drivers/net/phy/mdio_bus.c:165!



kernel BUG at drivers/net/phy/mdio_bus.c:165!
Unable to handle kernel NULL pointer dereference at virtual address 00000000

How?

mdiobus_alloc() sets bus->state = MDIOBUS_ALLOCATED.

mdiobus_register() sets bus->state = MDIOBUS_REGISTERED but then can
   fail (mdiobus_scan()) returning an error to the caller.

The caller aborts correctly with mdiobus_free() which does:
        if (bus->state == MDIOBUS_ALLOCATED) {
                kfree(bus);
                return;
        }

        BUG_ON(bus->state != MDIOBUS_UNREGISTERED);

Signed-off-by: Krzysztof Halasa <khc@pm.waw.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9a3de255

drivers/net/phy/mdio_bus.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -105,8 +105,6 @@ int mdiobus_register(struct mii_bus *bus)
		return -EINVAL;
		}

		bus->state = MDIOBUS_REGISTERED;

		mutex_init(&bus->mdio_lock);

		if (bus->reset)
		@@ -123,6 +121,9 @@ int mdiobus_register(struct mii_bus *bus)
		}
		}

		if (!err)
		bus->state = MDIOBUS_REGISTERED;

		pr_info("%s: probed\n", bus->name);

		return err;

Admin message