Commit e8cf6616 authored by Jon Hunter's avatar Jon Hunter Committed by Thierry Reding
Browse files

soc/tegra: pmc: Protect public functions from potential race conditions 



The PMC base address pointer is initialised during early boot so that
early platform code may used the PMC public functions. During the probe
of the PMC driver the base address pointer is mapped again and the initial
mapping is freed. This exposes a window where a device accessing the PMC
registers via one of the public functions, could race with the updating
of the pointer and lead to a invalid access. Furthermore, the only
protection between multiple devices attempting to access the PMC registers
is when setting the powergate state to on or off. None of the other public
functions that access the PMC registers are protected.

Use the existing mutex to protect paths that may race with regard to
accessing the PMC registers.

Note that functions tegra_io_rail_prepare()/poll() either return a
negative value on failure or zero on success. Therefore, it is not
necessary to check if the return value is less than zero and so only
test that the return value is not zero to test for failure. This
simplifies the error handling with the mutex locking in place.

Signed-off-by: default avatarJon Hunter <jonathanh@nvidia.com>
Reviewed-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent 0259f522

drivers/soc/tegra/pmc.c

+33 −14
Original line number Original line Diff line number Diff line
@@ -235,7 +235,10 @@ int tegra_powergate_is_powered(int id) 
	if (!pmc->soc || id < 0 || id >= pmc->soc->num_powergates)

	if (!pmc->soc || id < 0 || id >= pmc->soc->num_powergates)

		return -EINVAL;

		return -EINVAL;





	mutex_lock(&pmc->powergates_lock);

	status = tegra_pmc_readl(PWRGATE_STATUS) & (1 << id);

	status = tegra_pmc_readl(PWRGATE_STATUS) & (1 << id);

	mutex_unlock(&pmc->powergates_lock);



	return !!status;

	return !!status;

}

}
@@ -250,6 +253,8 @@ int tegra_powergate_remove_clamping(int id) 
	if (!pmc->soc || id < 0 || id >= pmc->soc->num_powergates)

	if (!pmc->soc || id < 0 || id >= pmc->soc->num_powergates)

		return -EINVAL;

		return -EINVAL;





	mutex_lock(&pmc->powergates_lock);



	/*

	/*

	 * On Tegra124 and later, the clamps for the GPU are controlled by a

	 * On Tegra124 and later, the clamps for the GPU are controlled by a

	 * separate register (with different semantics).

	 * separate register (with different semantics).
@@ -257,7 +262,7 @@ int tegra_powergate_remove_clamping(int id) 
	if (id == TEGRA_POWERGATE_3D) {

	if (id == TEGRA_POWERGATE_3D) {

		if (pmc->soc->has_gpu_clamps) {

		if (pmc->soc->has_gpu_clamps) {

			tegra_pmc_writel(0, GPU_RG_CNTRL);

			tegra_pmc_writel(0, GPU_RG_CNTRL);

			return 0;

			goto out;

		}

		}

	}

	}
@@ -274,6 +279,9 @@ int tegra_powergate_remove_clamping(int id) 




	tegra_pmc_writel(mask, REMOVE_CLAMPING);

	tegra_pmc_writel(mask, REMOVE_CLAMPING);





out:

	mutex_unlock(&pmc->powergates_lock);



	return 0;

	return 0;

}

}

EXPORT_SYMBOL(tegra_powergate_remove_clamping);

EXPORT_SYMBOL(tegra_powergate_remove_clamping);
@@ -520,9 +528,11 @@ int tegra_io_rail_power_on(int id) 
	unsigned int bit, mask;

	unsigned int bit, mask;

	int err;

	int err;





	mutex_lock(&pmc->powergates_lock);



	err = tegra_io_rail_prepare(id, &request, &status, &bit);

	err = tegra_io_rail_prepare(id, &request, &status, &bit);

	if (err < 0)

	if (err)

		return err;

		goto error;





	mask = 1 << bit;

	mask = 1 << bit;
@@ -533,14 +543,17 @@ int tegra_io_rail_power_on(int id) 
	tegra_pmc_writel(value, request);

	tegra_pmc_writel(value, request);





	err = tegra_io_rail_poll(status, mask, 0, 250);

	err = tegra_io_rail_poll(status, mask, 0, 250);

	if (err < 0) {

	if (err) {

		pr_info("tegra_io_rail_poll() failed: %d\n", err);

		pr_info("tegra_io_rail_poll() failed: %d\n", err);

		return err;

		goto error;

	}

	}





	tegra_io_rail_unprepare();

	tegra_io_rail_unprepare();





	return 0;

error:

	mutex_unlock(&pmc->powergates_lock);



	return err;

}

}

EXPORT_SYMBOL(tegra_io_rail_power_on);

EXPORT_SYMBOL(tegra_io_rail_power_on);
@@ -550,10 +563,12 @@ int tegra_io_rail_power_off(int id) 
	unsigned int bit, mask;

	unsigned int bit, mask;

	int err;

	int err;





	mutex_lock(&pmc->powergates_lock);



	err = tegra_io_rail_prepare(id, &request, &status, &bit);

	err = tegra_io_rail_prepare(id, &request, &status, &bit);

	if (err < 0) {

	if (err) {

		pr_info("tegra_io_rail_prepare() failed: %d\n", err);

		pr_info("tegra_io_rail_prepare() failed: %d\n", err);

		return err;

		goto error;

	}

	}





	mask = 1 << bit;

	mask = 1 << bit;
@@ -565,12 +580,15 @@ int tegra_io_rail_power_off(int id) 
	tegra_pmc_writel(value, request);

	tegra_pmc_writel(value, request);





	err = tegra_io_rail_poll(status, mask, mask, 250);

	err = tegra_io_rail_poll(status, mask, mask, 250);

	if (err < 0)

	if (err)

		return err;

		goto error;





	tegra_io_rail_unprepare();

	tegra_io_rail_unprepare();





	return 0;

error:

	mutex_unlock(&pmc->powergates_lock);



	return err;

}

}

EXPORT_SYMBOL(tegra_io_rail_power_off);

EXPORT_SYMBOL(tegra_io_rail_power_off);
@@ -807,7 +825,7 @@ out: 




static int tegra_pmc_probe(struct platform_device *pdev)

static int tegra_pmc_probe(struct platform_device *pdev)

{

{

	void __iomem *base, *tmp;

	void __iomem *base;

	struct resource *res;

	struct resource *res;

	int err;

	int err;
@@ -848,9 +866,10 @@ static int tegra_pmc_probe(struct platform_device *pdev) 
		return err;

		return err;

	}

	}





	tmp = pmc->base;

	mutex_lock(&pmc->powergates_lock);

	iounmap(pmc->base);

	pmc->base = base;

	pmc->base = base;

	iounmap(tmp);

	mutex_unlock(&pmc->powergates_lock);





	return 0;

	return 0;

}

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE