Commit e8baf7ab authored Mar 07, 2019 by Nathan Chancellor Committed by David Sterba Apr 29, 2019

btrfs: Turn an 'else if' into an 'else' in btrfs_uuid_tree_add

When building with -Wsometimes-uninitialized, Clang warns:

fs/btrfs/uuid-tree.c:129:13: warning: variable 'eb' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
fs/btrfs/uuid-tree.c:129:13: warning: variable 'offset' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]

Clang can't tell that all cases are covered with this final else if.
Just turn it into an else so that it is clear.

Link: https://github.com/ClangBuiltLinux/linux/issues/385

Suggested-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent 262c96a3

fs/btrfs/uuid-tree.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -126,7 +126,7 @@ int btrfs_uuid_tree_add(struct btrfs_trans_handle trans, u8 uuid, u8 type,
		slot = path->slots[0];
		offset = btrfs_item_ptr_offset(eb, slot);
		offset += btrfs_item_size_nr(eb, slot) - sizeof(subid_le);
		} else if (ret < 0) {
		} else {
		btrfs_warn(fs_info,
		"insert uuid item failed %d (0x%016llx, 0x%016llx) type %u!",
		ret, (unsigned long long)key.objectid,