Commit e8b1202c authored Jul 10, 2014 by Johan Hedberg Committed by Marcel Holtmann Jul 10, 2014

Bluetooth: Fix advertising parameter update when toggling connectable



When we change the connectable state and have advertising enabled we
should update the advertising parameters no matter what. The code was
incorrectly only updating them if advertising was not already active.
This patch fixes the issue.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

parent c072d546

net/bluetooth/mgmt.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1882,8 +1882,8 @@ static int set_connectable(struct sock sk, struct hci_dev hdev, void *data,
		if (cp->val \|\| test_bit(HCI_FAST_CONNECTABLE, &hdev->dev_flags))
		write_fast_connectable(&req, false);

		if (test_bit(HCI_ADVERTISING, &hdev->dev_flags) &&
		!test_bit(HCI_LE_ADV, &hdev->dev_flags))
		/* Update the advertising parameters if necessary */
		if (test_bit(HCI_ADVERTISING, &hdev->dev_flags))
		enable_advertising(&req);

		err = hci_req_run(&req, set_connectable_complete);

Admin message