Commit e8a3a2a3 authored Jun 29, 2017 by Imre Deak

drm/i915/bxt, glk: Fix assert on conditions for DC9 enabling



What we want to assert based on the conditions required by Bspec is that
power well 2 is disabled, so no need to check for other power wells.
In addition we can only check if the driver's request is removed, the
actual state depends on whether the other request bits are set or not
(BIOS, KVMR, DEBUG). So check only the driver's request bit.

Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1498750622-14023-4-git-send-email-imre.deak@intel.com

parent edfda8e3

drivers/gpu/drm/i915/intel_runtime_pm.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -549,7 +549,9 @@ static void assert_can_enable_dc9(struct drm_i915_private *dev_priv)
		"DC9 already programmed to be enabled.\n");
		WARN_ONCE(I915_READ(DC_STATE_EN) & DC_STATE_EN_UPTO_DC5,
		"DC5 still not disabled to enable DC9.\n");
		WARN_ONCE(I915_READ(HSW_PWR_WELL_DRIVER), "Power well on.\n");
		WARN_ONCE(I915_READ(HSW_PWR_WELL_DRIVER) &
		SKL_POWER_WELL_REQ(SKL_DISP_PW_2),
		"Power well 2 on.\n");
		WARN_ONCE(intel_irqs_enabled(dev_priv),
		"Interrupts not disabled yet.\n");

Admin message