drivers/char/mxser.c: fix compilation warning in mxser.c (e89d67cf) · Commits · 戴 / test

Both mxser_disable_must_enchance_mode() and mxser_get_must_hardware_id() called from function CheckIsMoxaMust(), when CONFIG_PCI=y. So mark both the functions under CONFIG_PCI. We were warned by the following warning. drivers/char/mxser.c:306: warning: `mxser_disable_must_enchance_mode' defined but not used drivers/char/mxser.c:391: warning: `mxser_get_must_hardware_id' defined but not used Signed-off-by:

Rakib Mullick <rakib.mullick@gmail.com> Cc: Jiri Slaby <jirislaby@gmail.com> Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Signed-off-by:

Linus Torvalds <torvalds@linux-foundation.org>

drivers/char/mxser.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -303,6 +303,7 @@ static void mxser_enable_must_enchance_mode(unsigned long baseio)
		outb(oldlcr, baseio + UART_LCR);
		}

		#ifdef CONFIG_PCI
		static void mxser_disable_must_enchance_mode(unsigned long baseio)
		{
		u8 oldlcr;
		@@ -317,6 +318,7 @@ static void mxser_disable_must_enchance_mode(unsigned long baseio)
		outb(efr, baseio + MOXA_MUST_EFR_REGISTER);
		outb(oldlcr, baseio + UART_LCR);
		}
		#endif

		static void mxser_set_must_xon1_value(unsigned long baseio, u8 value)
		{
		@@ -388,6 +390,7 @@ static void mxser_set_must_enum_value(unsigned long baseio, u8 value)
		outb(oldlcr, baseio + UART_LCR);
		}

		#ifdef CONFIG_PCI
		static void mxser_get_must_hardware_id(unsigned long baseio, u8 *pId)
		{
		u8 oldlcr;
		@@ -404,6 +407,7 @@ static void mxser_get_must_hardware_id(unsigned long baseio, u8 *pId)
		*pId = inb(baseio + MOXA_MUST_HWID_REGISTER);
		outb(oldlcr, baseio + UART_LCR);
		}
		#endif

		static void SET_MOXA_MUST_NO_SOFTWARE_FLOW_CONTROL(unsigned long baseio)
		{

Admin message