Commit e88afe75 authored by Or Gerlitz's avatar Or Gerlitz Committed by Saeed Mahameed
Browse files

net/mlx5e: Err if asked to mirror a goto chain tc eswitch rule 



Currently we are not supporting this and not err-ing on that either.

For now, just err if asked to do that.

Fixes: bf07aa73 ('net/mlx5e: Support offloading tc priorities and chains for eswitch flows')
Signed-off-by: default avatarOr Gerlitz <ogerlitz@mellanox.com>
Reported-by: default avatarEli Britstein <elibr@mellanox.com>
Reviewed-by: default avatarEli Britstein <elibr@mellanox.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent e1c15b62

drivers/net/ethernet/mellanox/mlx5/core/en_tc.c

+9 −2
Original line number Diff line number Diff line
@@ -2966,8 +2966,7 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv, struct tcf_exts *exts, 
				NL_SET_ERR_MSG(extack, "Requested destination chain is out of supported range");

				return -EOPNOTSUPP;

			}

			action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST |

				  MLX5_FLOW_CONTEXT_ACTION_COUNT;

			action |= MLX5_FLOW_CONTEXT_ACTION_COUNT;

			attr->dest_chain = dest_chain;



			continue;
@@ -2980,6 +2979,14 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv, struct tcf_exts *exts, 
	if (!actions_match_supported(priv, exts, parse_attr, flow, extack))

		return -EOPNOTSUPP;



	if (attr->dest_chain) {

		if (attr->action & MLX5_FLOW_CONTEXT_ACTION_FWD_DEST) {

			NL_SET_ERR_MSG(extack, "Mirroring goto chain rules isn't supported");

			return -EOPNOTSUPP;

		}

		attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST;

	}



	if (attr->mirror_count > 0 && !mlx5_esw_has_fwd_fdb(priv->mdev)) {

		NL_SET_ERR_MSG_MOD(extack,

				   "current firmware doesn't support split rule for port mirroring");

CRA Git | Maintained and supported by SUSTech CRA and CCSE