Commit e88904bf authored Nov 12, 2020 by Lee Jones Committed by Sam Ravnborg Nov 12, 2020

drm/sti/sti_hdmi: Move 'colorspace_mode_names' array to where its used



Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/sti/sti_hdmi.h:36:40: warning: ‘colorspace_mode_names’ defined but not used [-Wunused-const-variable=]
 36 | static const struct drm_prop_enum_list colorspace_mode_names[] = {
 | ^~~~~~~~~~~~~~~~~~~~~

Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Vincent Abriou <vincent.abriou@st.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20201112190039.2785914-28-lee.jones@linaro.org

parent e232e3d4

drivers/gpu/drm/sti/sti_hdmi.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -167,6 +167,12 @@ struct sti_hdmi_connector {
		#define to_sti_hdmi_connector(x) \
		container_of(x, struct sti_hdmi_connector, drm_connector)

		static const struct drm_prop_enum_list colorspace_mode_names[] = {
		{ HDMI_COLORSPACE_RGB, "rgb" },
		{ HDMI_COLORSPACE_YUV422, "yuv422" },
		{ HDMI_COLORSPACE_YUV444, "yuv444" },
		};

		u32 hdmi_read(struct sti_hdmi *hdmi, int offset)
		{
		return readl(hdmi->regs + offset);

drivers/gpu/drm/sti/sti_hdmi.h

+0 −6

Original line number	Diff line number	Diff line
		@@ -33,12 +33,6 @@ struct hdmi_audio_params {
		struct hdmi_audio_infoframe cea;
		};

		static const struct drm_prop_enum_list colorspace_mode_names[] = {
		{ HDMI_COLORSPACE_RGB, "rgb" },
		{ HDMI_COLORSPACE_YUV422, "yuv422" },
		{ HDMI_COLORSPACE_YUV444, "yuv444" },
		};

		#define DEFAULT_COLORSPACE_MODE HDMI_COLORSPACE_RGB

		/**

Admin message