PM / devfreq: Fix devfreq_notifier_call returning errno (e876e710) · Commits · 戴 / test

Notifier callbacks shouldn't return negative errno but one of the NOTIFY_OK/DONE/BAD values. The OPP core will ignore return values from notifiers but returning a value that matches NOTIFY_STOP_MASK will stop the notification chain. Fix by always returning NOTIFY_OK. Signed-off-by:

Leonard Crestez <leonard.crestez@nxp.com> Reviewed-by:

Matthias Kaehlcke <mka@chromium.org> Reviewed-by:

Chanwoo Choi <cw00.choi@samsung.com> Signed-off-by:

Chanwoo Choi <cw00.choi@samsung.com>

drivers/devfreq/devfreq.c

+13 −11

Original line number	Diff line number	Diff line
		@@ -568,26 +568,28 @@ static int devfreq_notifier_call(struct notifier_block *nb, unsigned long type,
		void *devp)
		{
		struct devfreq *devfreq = container_of(nb, struct devfreq, nb);
		int ret;
		int err = -EINVAL;

		mutex_lock(&devfreq->lock);

		devfreq->scaling_min_freq = find_available_min_freq(devfreq);
		if (!devfreq->scaling_min_freq) {
		mutex_unlock(&devfreq->lock);
		return -EINVAL;
		}
		if (!devfreq->scaling_min_freq)
		goto out;

		devfreq->scaling_max_freq = find_available_max_freq(devfreq);
		if (!devfreq->scaling_max_freq) {
		mutex_unlock(&devfreq->lock);
		return -EINVAL;
		}
		if (!devfreq->scaling_max_freq)
		goto out;

		err = update_devfreq(devfreq);

		ret = update_devfreq(devfreq);
		out:
		mutex_unlock(&devfreq->lock);
		if (err)
		dev_err(devfreq->dev.parent,
		"failed to update frequency from OPP notifier (%d)\n",
		err);

		return ret;
		return NOTIFY_OK;
		}

		/**

Admin message