Commit e8698301 authored Dec 10, 2018 by Arnd Bergmann Committed by Luca Coelho Feb 20, 2019

iwlwifi: fix false-positive maybe-uninitialized warning

With CONFIG_NO_AUTO_INLINE, we run into a silly warning when
gcc fails to remember that n_profiles is constant across
the function call to iwl_mvm_sar_set_profile:

drivers/net/wireless/intel/iwlwifi/mvm/fw.c: In function 'iwl_mvm_sar_get_ewrd_table':
drivers/net/wireless/intel/iwlwifi/mvm/fw.c:746:9: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Marking that function 'inline' avoids the warning.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

parent 1e78e759

drivers/net/wireless/intel/iwlwifi/mvm/fw.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -646,7 +646,7 @@ static int iwl_mvm_config_ltr(struct iwl_mvm *mvm)
		}

		#ifdef CONFIG_ACPI
		static int iwl_mvm_sar_set_profile(struct iwl_mvm *mvm,
		static inline int iwl_mvm_sar_set_profile(struct iwl_mvm *mvm,
		union acpi_object *table,
		struct iwl_mvm_sar_profile *profile,
		bool enabled)

Admin message