Commit e839b6a1 authored Sep 12, 2013 by Michal Hocko Committed by Linus Torvalds Sep 12, 2013

memcg, vmscan: do not attempt soft limit reclaim if it would not scan anything



mem_cgroup_should_soft_reclaim controls whether soft reclaim pass is
done and it always says yes currently.  Memcg iterators are clever to
skip nodes that are not soft reclaimable quite efficiently but
mem_cgroup_should_soft_reclaim can be more clever and do not start the
soft reclaim pass at all if it knows that nothing would be scanned
anyway.

In order to do that, simply reuse mem_cgroup_soft_reclaim_eligible for
the target group of the reclaim and allow the pass only if the whole
subtree wouldn't be skipped.

Signed-off-by: Michal Hocko <mhocko@suse.cz>
Cc: Balbir Singh <bsingharora@gmail.com>
Cc: Glauber Costa <glommer@openvz.org>
Cc: Greg Thelen <gthelen@google.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Michel Lespinasse <walken@google.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Ying Han <yinghan@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 7d910c05

mm/memcontrol.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -1885,7 +1885,11 @@ enum mem_cgroup_filter_t
		mem_cgroup_soft_reclaim_eligible(struct mem_cgroup *memcg,
		struct mem_cgroup *root)
		{
		struct mem_cgroup *parent = memcg;
		struct mem_cgroup *parent;

		if (!memcg)
		memcg = root_mem_cgroup;
		parent = memcg;

		if (res_counter_soft_limit_excess(&memcg->res))
		return VISIT;

mm/vmscan.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -142,7 +142,9 @@ static bool global_reclaim(struct scan_control *sc)

		static bool mem_cgroup_should_soft_reclaim(struct scan_control *sc)
		{
		return !mem_cgroup_disabled();
		struct mem_cgroup *root = sc->target_mem_cgroup;
		return !mem_cgroup_disabled() &&
		mem_cgroup_soft_reclaim_eligible(root, root) != SKIP_TREE;
		}
		#else
		static bool global_reclaim(struct scan_control *sc)

Admin message