Commit e82adc10 authored Mar 18, 2019 by Gustavo A. R. Silva Committed by Greg Kroah-Hartman Mar 19, 2019

usb: typec: Fix unchecked return value



Currently there is no check on platform_get_irq() return value
in case it fails, hence never actually reporting any errors and
causing unexpected behavior when using such value as argument
for function regmap_irq_get_virq().

Fix this by adding a proper check, a message error and return
*irq* in case platform_get_irq() fails.

Addresses-Coverity-ID: 1443899 ("Improper use of negative value")
Fixes: d2061f9c ("usb: typec: add driver for Intel Whiskey Cove PMIC USB Type-C PHY")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9e98c678

drivers/usb/typec/tcpm/wcove.c

+7 −2

Original line number	Diff line number	Diff line
		@@ -615,8 +615,13 @@ static int wcove_typec_probe(struct platform_device *pdev)
		wcove->dev = &pdev->dev;
		wcove->regmap = pmic->regmap;

		irq = regmap_irq_get_virq(pmic->irq_chip_data_chgr,
		platform_get_irq(pdev, 0));
		irq = platform_get_irq(pdev, 0);
		if (irq < 0) {
		dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq);
		return irq;
		}

		irq = regmap_irq_get_virq(pmic->irq_chip_data_chgr, irq);
		if (irq < 0)
		return irq;

Admin message