Commit e8184a47 authored Oct 04, 2010 by Paul Mundt

sh: pfc: Fix up BUG() triggered by gpiolib debugfs lookups.

The gpiolib debugfs entry takes a hammer approach and iterates over all
of the potential GPIOs, regardless of their type. The SH PFC code on the
other hand contains a variable mismash of input/output/function types
spread out sparsely, leading to situations where the debug code can
trigger an out of range enum for the type. Since we already have an error
path for out of range enums, we can just hand that up to the higher level
instead of the current BUG() behaviour.

Signed-off-by: Paul Mundt <lethal@linux-sh.org>

parent 872f36a6

drivers/sh/pfc.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -561,10 +561,8 @@ static int sh_gpio_get_value(struct pinmux_info *gpioc, unsigned gpio)
		struct pinmux_data_reg *dr = NULL;
		int bit = 0;

		if (!gpioc \|\| get_data_reg(gpioc, gpio, &dr, &bit) != 0) {
		BUG();
		return 0;
		}
		if (!gpioc \|\| get_data_reg(gpioc, gpio, &dr, &bit) != 0)
		return -EINVAL;

		return gpio_read_reg(dr->reg, dr->reg_width, 1, bit);
		}

Admin message