Commit e7f0c424 authored Feb 13, 2019 by zhangyi (F) Committed by Steven Rostedt (VMware) Feb 20, 2019

tracing: Do not free iter->trace in fail path of tracing_open_pipe()

Commit d716ff71 ("tracing: Remove taking of trace_types_lock in
pipe files") use the current tracer instead of the copy in
tracing_open_pipe(), but it forget to remove the freeing sentence in
the error path.

There's an error path that can call kfree(iter->trace) after the iter->trace
was assigned to tr->current_trace, which would be bad to free.

Link: http://lkml.kernel.org/r/1550060946-45984-1-git-send-email-yi.zhang@huawei.com



Cc: stable@vger.kernel.org
Fixes: d716ff71 ("tracing: Remove taking of trace_types_lock in pipe files")
Signed-off-by: zhangyi (F) <yi.zhang@huawei.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

parent ce59b8e9

kernel/trace/trace.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -5624,7 +5624,6 @@ out:
		return ret;

		fail:
		kfree(iter->trace);
		kfree(iter);
		__trace_array_put(tr);
		mutex_unlock(&trace_types_lock);

Admin message