Commit e7efe593 authored Jan 03, 2010 by Douglas Gilbert Committed by James Bottomley Jan 18, 2010

[SCSI] skip sense logging for some ATA PASS-THROUGH cdbs



Further to the lsml thread titled:
"does scsi_io_completion need to dump sense data for ata pass through (ck_cond =
1) ?"

This is a patch to skip logging when the sense data is
associated with a SENSE_KEY of "RECOVERED_ERROR" and the
additional sense code is "ATA PASS-THROUGH INFORMATION
AVAILABLE". This only occurs with the SAT ATA PASS-THROUGH
commands when CK_COND=1 (in the cdb). It indicates that
the sense data contains ATA registers.

Smartmontools uses such commands on ATA disks connected via
SAT. Periodic checks such as those done by smartd cause
nuisance entries into logs that are:
    - neither errors nor warnings
    - pointless unless the cdb that caused them are also logged

Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>

parent 5d7ebb9c

drivers/scsi/scsi_lib.c

+8 −2

Original line number	Diff line number	Diff line
		@@ -773,8 +773,14 @@ void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes)
		* we already took a copy of the original into rq->errors which
		* is what gets returned to the user
		*/
		if (sense_valid && sshdr.sense_key == RECOVERED_ERROR) {
		if (!(req->cmd_flags & REQ_QUIET))
		if (sense_valid && (sshdr.sense_key == RECOVERED_ERROR)) {
		/* if ATA PASS-THROUGH INFORMATION AVAILABLE skip
		* print since caller wants ATA registers. Only occurs on
		* SCSI ATA PASS_THROUGH commands when CK_COND=1
		*/
		if ((sshdr.asc == 0x0) && (sshdr.ascq == 0x1d))
		;
		else if (!(req->cmd_flags & REQ_QUIET))
		scsi_print_sense("", cmd);
		result = 0;
		/* BLOCK_PC may have set error */

Admin message