Commit e7ed83d6 authored Jun 04, 2020 by Dan Carpenter Committed by Daniel Borkmann Jun 04, 2020

bpf: Fix an error code in check_btf_func()



This code returns success if the "info_aux" allocation fails but it
should return -ENOMEM.

Fixes: 8c1b6e69 ("bpf: Compare BTF types of functions arguments with actual types")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Song Liu <songliubraving@fb.com>
Link: https://lore.kernel.org/bpf/20200604085436.GA943001@mwanda

parent 49b23575

kernel/bpf/verifier.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -7552,7 +7552,7 @@ static int check_btf_func(struct bpf_verifier_env *env,
		const struct btf *btf;
		void __user *urecord;
		u32 prev_offset = 0;
		int ret = 0;
		int ret = -ENOMEM;

		nfuncs = attr->func_info_cnt;
		if (!nfuncs)

Admin message