Commit e7e16f48 authored by Johannes Thumshirn's avatar Johannes Thumshirn Committed by David Sterba
Browse files

btrfs: add common checksum type validation 



Currently btrfs is only supporting CRC32C as checksumming algorithm. As
this is about to change provide a function to validate the checksum type
in the superblock against all possible algorithms.

This makes adding new algorithms easier as there are fewer places to
adjust when adding new algorithms.

Reviewed-by: default avatarNikolay Borisov <nborisov@suse.com>
Signed-off-by: default avatarJohannes Thumshirn <jthumshirn@suse.de>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 7ebc7e5f

fs/btrfs/disk-io.c

+19 −10
Original line number Diff line number Diff line
@@ -352,6 +352,16 @@ out: 
	return ret;

}



static bool btrfs_supported_super_csum(u16 csum_type)

{

	switch (csum_type) {

	case BTRFS_CSUM_TYPE_CRC32:

		return true;

	default:

		return false;

	}

}



/*

 * Return 0 if the superblock checksum type matches the checksum value of that

 * algorithm. Pass the raw disk superblock data.
@@ -362,7 +372,12 @@ static int btrfs_check_super_csum(struct btrfs_fs_info *fs_info, 
	struct btrfs_super_block *disk_sb =

		(struct btrfs_super_block *)raw_disk_sb;

	u16 csum_type = btrfs_super_csum_type(disk_sb);

	int ret = 0;



	if (!btrfs_supported_super_csum(csum_type)) {

		btrfs_err(fs_info, "unsupported checksum algorithm %u",

			  csum_type);

		return 1;

	}



	if (csum_type == BTRFS_CSUM_TYPE_CRC32) {

		u32 crc = ~(u32)0;
@@ -378,16 +393,10 @@ static int btrfs_check_super_csum(struct btrfs_fs_info *fs_info, 
		btrfs_csum_final(crc, result);



		if (memcmp(raw_disk_sb, result, sizeof(result)))

			ret = 1;

	}



	if (csum_type >= ARRAY_SIZE(btrfs_csum_sizes)) {

		btrfs_err(fs_info, "unsupported checksum algorithm %u",

				csum_type);

		ret = 1;

			return 1;

	}



	return ret;

	return 0;

}



int btrfs_verify_level_key(struct extent_buffer *eb, int level,
@@ -2572,7 +2581,7 @@ static int btrfs_validate_write_super(struct btrfs_fs_info *fs_info, 
	ret = validate_super(fs_info, sb, -1);

	if (ret < 0)

		goto out;

	if (btrfs_super_csum_type(sb) != BTRFS_CSUM_TYPE_CRC32) {

	if (!btrfs_supported_super_csum(btrfs_super_csum_type(sb))) {

		ret = -EUCLEAN;

		btrfs_err(fs_info, "invalid csum type, has %u want %u",

			  btrfs_super_csum_type(sb), BTRFS_CSUM_TYPE_CRC32);

CRA Git | Maintained and supported by SUSTech CRA and CCSE