HID: wacom: don't apply generic settings to old devices (e7deb157) · Commits · 戴 / test

Non-generic devices have numbered_buttons set for both pen and touch interfaces by default. The actual number of buttons on the interface is normally manually decided later, which is different from what those HID generic devices are processed, where number of buttons are directly retrieved from HID descriptors. This patch adds the missed HID_GENERIC check and moves the statement to wacom_setup_pad_input_capabilities since it's not a quirk anymore. Signed-off-by:

Ping Cheng <ping.cheng@wacom.com> Reviewed-by:

Jason Gerecke <jason.gerecke@wacom.com> Signed-off-by:

Jiri Kosina <jkosina@suse.cz>

drivers/hid/wacom_wac.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -2987,8 +2987,6 @@ void wacom_setup_device_quirks(struct wacom *wacom)
		struct wacom_features *features = &wacom->wacom_wac.features;

		/* The pen and pad share the same interface on most devices */
		if (features->numbered_buttons > 0)
		features->device_type \|= WACOM_DEVICETYPE_PAD;
		if (features->type == GRAPHIRE_BT \|\| features->type == WACOM_G4 \|\|
		features->type == DTUS \|\|
		(features->type >= INTUOS3S && features->type <= WACOM_MO)) {
		@@ -3527,6 +3525,9 @@ int wacom_setup_pad_input_capabilities(struct input_dev *input_dev,
		{
		struct wacom_features *features = &wacom_wac->features;

		if ((features->type == HID_GENERIC) && features->numbered_buttons > 0)
		features->device_type \|= WACOM_DEVICETYPE_PAD;

		if (!(features->device_type & WACOM_DEVICETYPE_PAD))
		return -ENODEV;

Admin message