Commit e7de2590 authored Jul 20, 2018 by Hailong Liu Committed by Greg Kroah-Hartman Jul 21, 2018

uio: fix wrong return value from uio_mmap()



uio_mmap has multiple fail paths to set return value to nonzero then
goto out. However, it always returns *0* from the *out* at end, and
this will mislead callers who check the return value of this function.

Fixes: 57c5f4df ("uio: fix crash after the device is unregistered")
CC: Xiubo Li <xiubli@redhat.com>
Signed-off-by: Hailong Liu <liu.hailong6@zte.com.cn>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Jiang Biao <jiang.biao2@zte.com.cn>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent fbb5858c

drivers/uio/uio.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -813,7 +813,7 @@ static int uio_mmap(struct file filep, struct vm_area_struct vma)

		out:
		mutex_unlock(&idev->info_lock);
		return 0;
		return ret;
		}

		static const struct file_operations uio_fops = {

Admin message