Commit e7d5e412 authored Jan 22, 2017 by Bjorn Andersson Committed by Kishon Vijay Abraham I Jan 27, 2017

phy: qcom-ufs: Don't kfree devres resource



Upon failing to acquire regulator supplies the qcom-ufs driver calls
kfree() on the devm allocated memory used to store the name of the
regulator, leading to devres corruption.

Rather than switching to using the appropriate free function the patch
acknowledge the fact that "name" is always a constant string and we
don't actually need to create a local copy of it, but rather just
reference the constant string.

Fixes: add78fc0 ("phy: qcom-ufs: Use devm sibling of kstrdup for regulator names")
Cc: stable@vger.kernel.org
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

parent e2427b09

drivers/phy/phy-qcom-ufs.c

+1 −8

Original line number	Diff line number	Diff line
		@@ -217,12 +217,7 @@ static int __ufs_qcom_phy_init_vreg(struct device *dev,

		char prop_name[MAX_PROP_NAME];

		vreg->name = devm_kstrdup(dev, name, GFP_KERNEL);
		if (!vreg->name) {
		err = -ENOMEM;
		goto out;
		}

		vreg->name = name;
		vreg->reg = devm_regulator_get(dev, name);
		if (IS_ERR(vreg->reg)) {
		err = PTR_ERR(vreg->reg);
		@@ -265,8 +260,6 @@ static int __ufs_qcom_phy_init_vreg(struct device *dev,
		}

		out:
		if (err)
		kfree(vreg->name);
		return err;
		}

Admin message