Commit e7c0c3fa authored by NeilBrown's avatar NeilBrown
Browse files

md/raid10: close race that lose writes lost when replacement completes. 



When a replacement operation completes there is a small window
when the original device is marked 'faulty' and the replacement
still looks like a replacement.  The faulty should be removed and
the replacement moved in place very quickly, bit it isn't instant.

So the code write out to the array must handle the possibility that
the only working device for some slot in the replacement - but it
doesn't.  If the primary device is faulty it just gives up.  This
can lead to corruption.

So make the code more robust: if either  the primary or the
replacement is present and working, write to them.  Only when
neither are present do we give up.

This bug has been present since replacement was introduced in
3.3, so it is suitable for any -stable kernel since then.

Reported-by: default avatar"George Spelvin" <linux@horizon.com>
Cc: stable@vger.kernel.org
Signed-off-by: default avatarNeilBrown <neilb@suse.de>
parent ca64cae9

drivers/md/raid10.c

+68 −61
Original line number Original line Diff line number Diff line
@@ -1334,18 +1334,21 @@ retry_write: 
			blocked_rdev = rrdev;

			blocked_rdev = rrdev;

			break;

			break;

		}

		}

		if (rdev && (test_bit(Faulty, &rdev->flags)

			     || test_bit(Unmerged, &rdev->flags)))

			rdev = NULL;

		if (rrdev && (test_bit(Faulty, &rrdev->flags)

		if (rrdev && (test_bit(Faulty, &rrdev->flags)

			      || test_bit(Unmerged, &rrdev->flags)))

			      || test_bit(Unmerged, &rrdev->flags)))

			rrdev = NULL;

			rrdev = NULL;





		r10_bio->devs[i].bio = NULL;

		r10_bio->devs[i].bio = NULL;

		r10_bio->devs[i].repl_bio = NULL;

		r10_bio->devs[i].repl_bio = NULL;

		if (!rdev || test_bit(Faulty, &rdev->flags) ||



		    test_bit(Unmerged, &rdev->flags)) {

		if (!rdev && !rrdev) {

			set_bit(R10BIO_Degraded, &r10_bio->state);

			set_bit(R10BIO_Degraded, &r10_bio->state);

			continue;

			continue;

		}

		}

		if (test_bit(WriteErrorSeen, &rdev->flags)) {

		if (rdev && test_bit(WriteErrorSeen, &rdev->flags)) {

			sector_t first_bad;

			sector_t first_bad;

			sector_t dev_sector = r10_bio->devs[i].addr;

			sector_t dev_sector = r10_bio->devs[i].addr;

			int bad_sectors;

			int bad_sectors;
@@ -1387,8 +1390,10 @@ retry_write: 
					max_sectors = good_sectors;

					max_sectors = good_sectors;

			}

			}

		}

		}

		if (rdev) {

			r10_bio->devs[i].bio = bio;

			r10_bio->devs[i].bio = bio;

			atomic_inc(&rdev->nr_pending);

			atomic_inc(&rdev->nr_pending);

		}

		if (rrdev) {

		if (rrdev) {

			r10_bio->devs[i].repl_bio = bio;

			r10_bio->devs[i].repl_bio = bio;

			atomic_inc(&rrdev->nr_pending);

			atomic_inc(&rrdev->nr_pending);
@@ -1444,9 +1449,8 @@ retry_write: 
	for (i = 0; i < conf->copies; i++) {

	for (i = 0; i < conf->copies; i++) {

		struct bio *mbio;

		struct bio *mbio;

		int d = r10_bio->devs[i].devnum;

		int d = r10_bio->devs[i].devnum;

		if (!r10_bio->devs[i].bio)

		if (r10_bio->devs[i].bio) {

			continue;

			struct md_rdev *rdev = conf->mirrors[d].rdev;



			mbio = bio_clone_mddev(bio, GFP_NOIO, mddev);

			mbio = bio_clone_mddev(bio, GFP_NOIO, mddev);

			md_trim_bio(mbio, r10_bio->sector - bio->bi_sector,

			md_trim_bio(mbio, r10_bio->sector - bio->bi_sector,

				    max_sectors);

				    max_sectors);
@@ -1454,17 +1458,19 @@ retry_write: 




			mbio->bi_sector	= (r10_bio->devs[i].addr+

			mbio->bi_sector	= (r10_bio->devs[i].addr+

					   choose_data_offset(r10_bio,

					   choose_data_offset(r10_bio,

						      conf->mirrors[d].rdev));

							      rdev));

		mbio->bi_bdev = conf->mirrors[d].rdev->bdev;

			mbio->bi_bdev = rdev->bdev;

			mbio->bi_end_io	= raid10_end_write_request;

			mbio->bi_end_io	= raid10_end_write_request;

			mbio->bi_rw = WRITE | do_sync | do_fua | do_discard;

			mbio->bi_rw = WRITE | do_sync | do_fua | do_discard;

			mbio->bi_private = r10_bio;

			mbio->bi_private = r10_bio;





			atomic_inc(&r10_bio->remaining);

			atomic_inc(&r10_bio->remaining);





		cb = blk_check_plugged(raid10_unplug, mddev, sizeof(*plug));

			cb = blk_check_plugged(raid10_unplug, mddev,

					       sizeof(*plug));

			if (cb)

			if (cb)

			plug = container_of(cb, struct raid10_plug_cb, cb);

				plug = container_of(cb, struct raid10_plug_cb,

						    cb);

			else

			else

				plug = NULL;

				plug = NULL;

			spin_lock_irqsave(&conf->device_lock, flags);

			spin_lock_irqsave(&conf->device_lock, flags);
@@ -1478,24 +1484,24 @@ retry_write: 
			spin_unlock_irqrestore(&conf->device_lock, flags);

			spin_unlock_irqrestore(&conf->device_lock, flags);

			if (!plug)

			if (!plug)

				md_wakeup_thread(mddev->thread);

				md_wakeup_thread(mddev->thread);

		}





		if (!r10_bio->devs[i].repl_bio)

		if (r10_bio->devs[i].repl_bio) {

			continue;

			struct md_rdev *rdev = conf->mirrors[d].replacement;



			if (rdev == NULL) {

				/* Replacement just got moved to main 'rdev' */

				smp_mb();

				rdev = conf->mirrors[d].rdev;

			}

			mbio = bio_clone_mddev(bio, GFP_NOIO, mddev);

			mbio = bio_clone_mddev(bio, GFP_NOIO, mddev);

			md_trim_bio(mbio, r10_bio->sector - bio->bi_sector,

			md_trim_bio(mbio, r10_bio->sector - bio->bi_sector,

				    max_sectors);

				    max_sectors);

			r10_bio->devs[i].repl_bio = mbio;

			r10_bio->devs[i].repl_bio = mbio;





		/* We are actively writing to the original device

		 * so it cannot disappear, so the replacement cannot

		 * become NULL here

		 */

			mbio->bi_sector	= (r10_bio->devs[i].addr +

			mbio->bi_sector	= (r10_bio->devs[i].addr +

					   choose_data_offset(

					   choose_data_offset(

					   r10_bio,

						   r10_bio, rdev));

					   conf->mirrors[d].replacement));

			mbio->bi_bdev = rdev->bdev;

		mbio->bi_bdev = conf->mirrors[d].replacement->bdev;

			mbio->bi_end_io	= raid10_end_write_request;

			mbio->bi_end_io	= raid10_end_write_request;

			mbio->bi_rw = WRITE | do_sync | do_fua | do_discard;

			mbio->bi_rw = WRITE | do_sync | do_fua | do_discard;

			mbio->bi_private = r10_bio;

			mbio->bi_private = r10_bio;
@@ -1508,6 +1514,7 @@ retry_write: 
			if (!mddev_check_plugged(mddev))

			if (!mddev_check_plugged(mddev))

				md_wakeup_thread(mddev->thread);

				md_wakeup_thread(mddev->thread);

		}

		}

	}





	/* Don't remove the bias on 'remaining' (one_write_done) until

	/* Don't remove the bias on 'remaining' (one_write_done) until

	 * after checking if we need to go around again.

	 * after checking if we need to go around again.

CRA Git | Maintained and supported by SUSTech CRA and CCSE