tipc: Eliminate timestamp from link protocol messages (e7b3acb6) · Commits · 戴 / test

Removes support for the timestamp field of TIPC's link protocol messages. This field was previously used to hold an OS-dependent timestamp value that was used to assist in debugging early versions of TIPC. The field has now been deemed unnecessary and has been removed from the latest TIPC specification. This change has no impact on the operation of TIPC since the field was set by TIPC, but never referenced. Signed-off-by:

Allan Stephens <Allan.Stephens@windriver.com> Signed-off-by:

Paul Gortmaker <paul.gortmaker@windriver.com>

net/tipc/link.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1977,7 +1977,6 @@ void tipc_link_send_proto_msg(struct link *l_ptr, u32 msg_typ, int probe_msg,
		skb_copy_to_linear_data(buf, msg, sizeof(l_ptr->proto_msg));
		return;
		}
		msg_set_timestamp(msg, jiffies_to_msecs(jiffies));

		/* Message can be sent */

net/tipc/msg.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -238,7 +238,6 @@ void tipc_msg_dbg(struct print_buf buf, struct tipc_msg msg, const char *str)
		tipc_printf(buf, "REROUTED(%u):", msg_reroute_cnt(msg));
		break;
		case LINK_PROTOCOL:
		tipc_printf(buf, "PROT:TIM(%u):", msg_timestamp(msg));
		switch (msg_type(msg)) {
		case STATE_MSG:
		tipc_printf(buf, "STATE:");

net/tipc/msg.h

+0 −10

Original line number	Diff line number	Diff line
		@@ -438,16 +438,6 @@ static inline void msg_set_nametype(struct tipc_msg *m, u32 n)
		msg_set_word(m, 8, n);
		}

		static inline void msg_set_timestamp(struct tipc_msg *m, u32 n)
		{
		msg_set_word(m, 8, n);
		}

		static inline u32 msg_timestamp(struct tipc_msg *m)
		{
		return msg_word(m, 8);
		}

		static inline u32 msg_nameinst(struct tipc_msg *m)
		{
		return msg_word(m, 9);

Admin message