Commit e7afb623 authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm: Add drm_any_plane_has_format() 



Add a function to check whether there is at least one plane that
supports a specific format and modifier combination. Drivers can
use this to reject unsupported formats/modifiers in .fb_create().

v2: Accept anyformat if the driver doesn't do planes (Eric)
    s/planes_have_format/any_plane_has_format/ (Eric)
    Check the modifier as well since we already have a function
    that does both
v3: Don't do the check in the core since we may not know the
    modifier yet, instead export the function and let drivers
    call it themselves

Cc: Eric Anholt <eric@anholt.net>
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: default avatarDhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181029183453.28541-1-ville.syrjala@linux.intel.com
parent 96802905

drivers/gpu/drm/drm_plane.c

+23 −0
Original line number Diff line number Diff line
@@ -636,6 +636,29 @@ static int __setplane_check(struct drm_plane *plane, 
	return 0;

}



/**

 * drm_any_plane_has_format - Check whether any plane supports this format and modifier combination

 * @dev: DRM device

 * @format: pixel format (DRM_FORMAT_*)

 * @modifier: data layout modifier

 *

 * Returns:

 * Whether at least one plane supports the specified format and modifier combination.

 */

bool drm_any_plane_has_format(struct drm_device *dev,

			      u32 format, u64 modifier)

{

	struct drm_plane *plane;



	drm_for_each_plane(plane, dev) {

		if (drm_plane_check_pixel_format(plane, format, modifier) == 0)

			return true;

	}



	return false;

}

EXPORT_SYMBOL(drm_any_plane_has_format);



/*

 * __setplane_internal - setplane handler for internal callers

 *

include/drm/drm_mode_config.h

+6 −0
Original line number Diff line number Diff line
@@ -52,6 +52,12 @@ struct drm_mode_config_funcs { 
	 * requested metadata, but most of that is left to the driver. See

	 * &struct drm_mode_fb_cmd2 for details.

	 *

	 * To validate the pixel format and modifier drivers can use

	 * drm_any_plane_has_format() to make sure at least one plane supports

	 * the requested values. Note that the driver must first determine the

	 * actual modifier used if the request doesn't have it specified,

	 * ie. when (@mode_cmd->flags & DRM_MODE_FB_MODIFIERS) == 0.

	 *

	 * If the parameters are deemed valid and the backing storage objects in

	 * the underlying memory manager all exist, then the driver allocates

	 * a new &drm_framebuffer structure, subclassed to contain

include/drm/drm_plane.h

+2 −0
Original line number Diff line number Diff line
@@ -798,5 +798,7 @@ static inline struct drm_plane *drm_plane_find(struct drm_device *dev, 
#define drm_for_each_plane(plane, dev) \

	list_for_each_entry(plane, &(dev)->mode_config.plane_list, head)



bool drm_any_plane_has_format(struct drm_device *dev,

			      u32 format, u64 modifier);



#endif

CRA Git | Maintained and supported by SUSTech CRA and CCSE