Commit e7a98105 authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller
Browse files

devlink: propagate extack down to health reporter ops 



During health reporter operations, driver might want to fill-up
the extack message, so propagate extack down to the health reporter ops.

Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 40281820

drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c

+6 −3
Original line number Diff line number Diff line
@@ -16,7 +16,8 @@ 
#include "bnxt_devlink.h"



static int bnxt_fw_reporter_diagnose(struct devlink_health_reporter *reporter,

				     struct devlink_fmsg *fmsg)

				     struct devlink_fmsg *fmsg,

				     struct netlink_ext_ack *extack)

{

	struct bnxt *bp = devlink_health_reporter_priv(reporter);

	struct bnxt_fw_health *health = bp->fw_health;
@@ -66,7 +67,8 @@ static const struct devlink_health_reporter_ops bnxt_dl_fw_reporter_ops = { 
};



static int bnxt_fw_reset_recover(struct devlink_health_reporter *reporter,

				 void *priv_ctx)

				 void *priv_ctx,

				 struct netlink_ext_ack *extack)

{

	struct bnxt *bp = devlink_health_reporter_priv(reporter);
@@ -84,7 +86,8 @@ struct devlink_health_reporter_ops bnxt_dl_fw_reset_reporter_ops = { 
};



static int bnxt_fw_fatal_recover(struct devlink_health_reporter *reporter,

				 void *priv_ctx)

				 void *priv_ctx,

				 struct netlink_ext_ack *extack)

{

	struct bnxt *bp = devlink_health_reporter_priv(reporter);

	struct bnxt_fw_reporter_ctx *fw_reporter_ctx = priv_ctx;

drivers/net/ethernet/mellanox/mlx5/core/en/reporter_rx.c

+4 −2
Original line number Diff line number Diff line
@@ -222,7 +222,8 @@ static int mlx5e_rx_reporter_recover_from_ctx(struct mlx5e_err_ctx *err_ctx) 
}



static int mlx5e_rx_reporter_recover(struct devlink_health_reporter *reporter,

				     void *context)

				     void *context,

				     struct netlink_ext_ack *extack)

{

	struct mlx5e_priv *priv = devlink_health_reporter_priv(reporter);

	struct mlx5e_err_ctx *err_ctx = context;
@@ -301,7 +302,8 @@ static int mlx5e_rx_reporter_build_diagnose_output(struct mlx5e_rq *rq, 
}



static int mlx5e_rx_reporter_diagnose(struct devlink_health_reporter *reporter,

				      struct devlink_fmsg *fmsg)

				      struct devlink_fmsg *fmsg,

				      struct netlink_ext_ack *extack)

{

	struct mlx5e_priv *priv = devlink_health_reporter_priv(reporter);

	struct mlx5e_params *params = &priv->channels.params;

drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c

+4 −2
Original line number Diff line number Diff line
@@ -135,7 +135,8 @@ static int mlx5e_tx_reporter_recover_from_ctx(struct mlx5e_err_ctx *err_ctx) 
}



static int mlx5e_tx_reporter_recover(struct devlink_health_reporter *reporter,

				     void *context)

				     void *context,

				     struct netlink_ext_ack *extack)

{

	struct mlx5e_priv *priv = devlink_health_reporter_priv(reporter);

	struct mlx5e_err_ctx *err_ctx = context;
@@ -205,7 +206,8 @@ mlx5e_tx_reporter_build_diagnose_output(struct devlink_fmsg *fmsg, 
}



static int mlx5e_tx_reporter_diagnose(struct devlink_health_reporter *reporter,

				      struct devlink_fmsg *fmsg)

				      struct devlink_fmsg *fmsg,

				      struct netlink_ext_ack *extack)

{

	struct mlx5e_priv *priv = devlink_health_reporter_priv(reporter);

	struct mlx5e_txqsq *generic_sq = priv->txq2sq[0];

drivers/net/ethernet/mellanox/mlx5/core/health.c

+8 −4
Original line number Diff line number Diff line
@@ -390,7 +390,8 @@ static void print_health_info(struct mlx5_core_dev *dev) 


static int

mlx5_fw_reporter_diagnose(struct devlink_health_reporter *reporter,

			  struct devlink_fmsg *fmsg)

			  struct devlink_fmsg *fmsg,

			  struct netlink_ext_ack *extack)

{

	struct mlx5_core_dev *dev = devlink_health_reporter_priv(reporter);

	struct mlx5_core_health *health = &dev->priv.health;
@@ -491,7 +492,8 @@ mlx5_fw_reporter_heath_buffer_data_put(struct mlx5_core_dev *dev, 


static int

mlx5_fw_reporter_dump(struct devlink_health_reporter *reporter,

		      struct devlink_fmsg *fmsg, void *priv_ctx)

		      struct devlink_fmsg *fmsg, void *priv_ctx,

		      struct netlink_ext_ack *extack)

{

	struct mlx5_core_dev *dev = devlink_health_reporter_priv(reporter);

	int err;
@@ -545,7 +547,8 @@ static const struct devlink_health_reporter_ops mlx5_fw_reporter_ops = { 


static int

mlx5_fw_fatal_reporter_recover(struct devlink_health_reporter *reporter,

			       void *priv_ctx)

			       void *priv_ctx,

			       struct netlink_ext_ack *extack)

{

	struct mlx5_core_dev *dev = devlink_health_reporter_priv(reporter);
@@ -555,7 +558,8 @@ mlx5_fw_fatal_reporter_recover(struct devlink_health_reporter *reporter, 
#define MLX5_CR_DUMP_CHUNK_SIZE 256

static int

mlx5_fw_fatal_reporter_dump(struct devlink_health_reporter *reporter,

			    struct devlink_fmsg *fmsg, void *priv_ctx)

			    struct devlink_fmsg *fmsg, void *priv_ctx,

			    struct netlink_ext_ack *extack)

{

	struct mlx5_core_dev *dev = devlink_health_reporter_priv(reporter);

	u32 crdump_size = dev->priv.health.crdump_size;

include/net/devlink.h

+5 −3
Original line number Diff line number Diff line
@@ -507,11 +507,13 @@ enum devlink_health_reporter_state { 
struct devlink_health_reporter_ops {

	char *name;

	int (*recover)(struct devlink_health_reporter *reporter,

		       void *priv_ctx);

		       void *priv_ctx, struct netlink_ext_ack *extack);

	int (*dump)(struct devlink_health_reporter *reporter,

		    struct devlink_fmsg *fmsg, void *priv_ctx);

		    struct devlink_fmsg *fmsg, void *priv_ctx,

		    struct netlink_ext_ack *extack);

	int (*diagnose)(struct devlink_health_reporter *reporter,

			struct devlink_fmsg *fmsg);

			struct devlink_fmsg *fmsg,

			struct netlink_ext_ack *extack);

};



/**

CRA Git | Maintained and supported by SUSTech CRA and CCSE