Commit e7a89ace authored Oct 16, 2014 by Ville Syrjälä Committed by Daniel Vetter Nov 04, 2014

drm/i915: Warn if panel power is already on when enabling it



We should never enable the panel power twice. That would indicate a bug
somewhere else as we would need to enable the port twice without
disabling it in between. Also print the port name.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

parent 3936fcf4

drivers/gpu/drm/i915/intel_dp.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -1629,10 +1629,10 @@ static void edp_panel_on(struct intel_dp *intel_dp)
		DRM_DEBUG_KMS("Turn eDP port %c panel power on\n",
		port_name(dp_to_dig_port(intel_dp)->port));

		if (edp_have_panel_power(intel_dp)) {
		DRM_DEBUG_KMS("eDP power already on\n");
		if (WARN(edp_have_panel_power(intel_dp),
		"eDP port %c panel power already on\n",
		port_name(dp_to_dig_port(intel_dp)->port)))
		return;
		}

		wait_panel_power_cycle(intel_dp);

Admin message