Commit e79d74ab authored Mar 12, 2015 by Takashi Iwai

ALSA: control: Fix breakage of user ctl element addition



In the commit [2225e79b: 'ALSA: core: reduce stack usage related
to snd_ctl_new()'], the id field of the newly added kctl is untouched,
thus all attribute like name string remain empty.  The fix is just to
add the forgotten memcpy of the id field.

Fixes: 2225e79b ('ALSA: core: reduce stack usage related to snd_ctl_new()')
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent e6826ef1

sound/core/control.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1267,6 +1267,7 @@ static int snd_ctl_elem_add(struct snd_ctl_file *file,
		err = snd_ctl_new(&kctl, count, access, file);
		if (err < 0)
		return err;
		memcpy(&kctl->id, &info->id, sizeof(kctl->id));
		kctl->private_data = kzalloc(sizeof(struct user_element) + private_size,
		GFP_KERNEL);
		if (kctl->private_data == NULL) {

Admin message