Commit e7987a06 authored Dec 23, 2018 by Julia Lawall Committed by Vinod Koul Jan 07, 2019

dmaengine: at_hdmac: drop useless LIST_HEAD

Drop LIST_HEAD where the variable it declares is never used.

tmp_list has been declared since the introduction of the driver
and has never been used.  The two declarations of list were
introduced with the containing functions but were also not used.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
identifier x;
@@
- LIST_HEAD(x);
  ... when != x
// </smpl>

Fixes: dc78baa2 ("dmaengine: at_hdmac: new driver for the Atmel AHB DMA Controller")
Fixes: 4facfe7f ("dmaengine: hdmac: Split device_control")
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent bfeffd15

drivers/dma/at_hdmac.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -134,7 +134,6 @@ static struct at_desc atc_desc_get(struct at_dma_chan atchan)
		struct at_desc *ret = NULL;
		unsigned long flags;
		unsigned int i = 0;
		LIST_HEAD(tmp_list);

		spin_lock_irqsave(&atchan->lock, flags);
		list_for_each_entry_safe(desc, _desc, &atchan->free_list, desc_node) {
		@@ -1387,8 +1386,6 @@ static int atc_pause(struct dma_chan *chan)
		int chan_id = atchan->chan_common.chan_id;
		unsigned long flags;

		LIST_HEAD(list);

		dev_vdbg(chan2dev(chan), "%s\n", __func__);

		spin_lock_irqsave(&atchan->lock, flags);
		@@ -1408,8 +1405,6 @@ static int atc_resume(struct dma_chan *chan)
		int chan_id = atchan->chan_common.chan_id;
		unsigned long flags;

		LIST_HEAD(list);

		dev_vdbg(chan2dev(chan), "%s\n", __func__);

		if (!atc_chan_is_paused(atchan))

Admin message