Commit e78dcbf4 authored by Andrii Nakryiko's avatar Andrii Nakryiko Committed by Daniel Borkmann
Browse files

libbpf: Handle invalid typedef emitted by old GCC 



Old GCC versions are producing invalid typedef for __gnuc_va_list
pointing to void. Special-case this and emit valid:

typedef __builtin_va_list __gnuc_va_list;

Reported-by: default avatarJohn Fastabend <john.fastabend@gmail.com>
Signed-off-by: default avatarAndrii Nakryiko <andriin@fb.com>
Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Acked-by: default avatarMartin KaFai Lau <kafai@fb.com>
Acked-by: default avatarJohn Fastabend <john.fastabend@gmail.com>
Link: https://lore.kernel.org/bpf/20191011032901.452042-1-andriin@fb.com
parent 40901784

tools/lib/bpf/btf_dump.c

+11 −0
Original line number Diff line number Diff line
@@ -975,6 +975,17 @@ static void btf_dump_emit_typedef_def(struct btf_dump *d, __u32 id, 
{

	const char *name = btf_dump_ident_name(d, id);



	/*

	 * Old GCC versions are emitting invalid typedef for __gnuc_va_list

	 * pointing to VOID. This generates warnings from btf_dump() and

	 * results in uncompilable header file, so we are fixing it up here

	 * with valid typedef into __builtin_va_list.

	 */

	if (t->type == 0 && strcmp(name, "__gnuc_va_list") == 0) {

		btf_dump_printf(d, "typedef __builtin_va_list __gnuc_va_list");

		return;

	}



	btf_dump_printf(d, "typedef ");

	btf_dump_emit_type_decl(d, t->type, name, lvl);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE