Commit e78181fe authored Nov 06, 2006 by Johannes Berg Committed by Jeff Garzik Nov 07, 2006

[PATCH] b44: change comment about irq mask register



Through some experimentation with the similarly built bcm43xx I came to
the conclusion that if the hw/firmware sets a bit in the interrupt
register, an interrupt will only be raised if that bit is included in
the interrupt mask. Hence, the interrupt mask is more like an interrupt
control mask.

This patch changes the comment to reflect that.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

parent c836b771

drivers/net/b44.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -908,8 +908,9 @@ static irqreturn_t b44_interrupt(int irq, void *dev_id)
		istat = br32(bp, B44_ISTAT);
		imask = br32(bp, B44_IMASK);

		/* ??? What the fuck is the purpose of the interrupt mask
		* ??? register if we have to mask it out by hand anyways?
		/* The interrupt mask register controls which interrupt bits
		* will actually raise an interrupt to the CPU when set by hw/firmware,
		* but doesn't mask off the bits.
		*/
		istat &= imask;
		if (istat) {

Admin message