ocfs2: unlock bh_state if bg check fails (e75ed71b) · Commits · 戴 / test

We should unlock bh_stat if bg->bg_free_bits_count > bg->bg_bits Link: http://lkml.kernel.org/r/1516843095-23680-1-git-send-email-ge.changwei@h3c.com Signed-off-by:

Changwei Ge <ge.changwei@h3c.com> Suggested-by:

Jan Kara <jack@suse.cz> Reviewed-by:

Andrew Morton <akpm@linux-foundation.org> Cc: Mark Fasheh <mfasheh@versity.com> Cc: Joel Becker <jlbec@evilplan.org> Cc: Junxiao Bi <junxiao.bi@oracle.com> Cc: Joseph Qi <jiangqi903@gmail.com> Cc: Changwei Ge <ge.changwei@h3c.com> Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Signed-off-by:

Linus Torvalds <torvalds@linux-foundation.org>

fs/ocfs2/suballoc.c

+2 −0

Original line number	Original line	Diff line number	Diff line
	@@ -2438,6 +2438,8 @@ static int ocfs2_block_group_clear_bits(handle_t *handle,
	}		}
	le16_add_cpu(&bg->bg_free_bits_count, num_bits);		le16_add_cpu(&bg->bg_free_bits_count, num_bits);
	if (le16_to_cpu(bg->bg_free_bits_count) > le16_to_cpu(bg->bg_bits)) {		if (le16_to_cpu(bg->bg_free_bits_count) > le16_to_cpu(bg->bg_bits)) {
			if (undo_fn)
			jbd_unlock_bh_state(group_bh);
	return ocfs2_error(alloc_inode->i_sb, "Group descriptor # %llu has bit count %u but claims %u are freed. num_bits %d\n",		return ocfs2_error(alloc_inode->i_sb, "Group descriptor # %llu has bit count %u but claims %u are freed. num_bits %d\n",
	(unsigned long long)le64_to_cpu(bg->bg_blkno),		(unsigned long long)le64_to_cpu(bg->bg_blkno),
	le16_to_cpu(bg->bg_bits),		le16_to_cpu(bg->bg_bits),

Admin message