Commit e7513f66 authored by Xiang Chen's avatar Xiang Chen Committed by Martin K. Petersen
Browse files

scsi: hisi_sas: replace "%p" with "%pK" 



The format specifier "%p" can leak kernel address, and use "%pK" instead.

Signed-off-by: default avatarXiang Chen <chenxiang66@hisilicon.com>
Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent a07b4876

drivers/scsi/hisi_sas/hisi_sas_main.c

+1 −1
Original line number Diff line number Diff line
@@ -2102,7 +2102,7 @@ _hisi_sas_internal_task_abort(struct hisi_hba *hisi_hba, 
	}



exit:

	dev_dbg(dev, "internal task abort: task to dev %016llx task=%p resp: 0x%x sts 0x%x\n",

	dev_dbg(dev, "internal task abort: task to dev %016llx task=%pK resp: 0x%x sts 0x%x\n",

		SAS_ADDR(device->sas_addr), task,

		task->task_status.resp, /* 0 is complete, -1 is undelivered */

		task->task_status.stat);

drivers/scsi/hisi_sas/hisi_sas_v2_hw.c

+3 −3
Original line number Diff line number Diff line
@@ -2393,7 +2393,7 @@ slot_complete_v2_hw(struct hisi_hba *hisi_hba, struct hisi_sas_slot *slot) 
			slot_err_v2_hw(hisi_hba, task, slot, 2);



		if (ts->stat != SAS_DATA_UNDERRUN)

			dev_info(dev, "erroneous completion iptt=%d task=%p dev id=%d CQ hdr: 0x%x 0x%x 0x%x 0x%x Error info: 0x%x 0x%x 0x%x 0x%x\n",

			dev_info(dev, "erroneous completion iptt=%d task=%pK dev id=%d CQ hdr: 0x%x 0x%x 0x%x 0x%x Error info: 0x%x 0x%x 0x%x 0x%x\n",

				 slot->idx, task, sas_dev->device_id,

				 complete_hdr->dw0, complete_hdr->dw1,

				 complete_hdr->act, complete_hdr->dw3,
@@ -2455,7 +2455,7 @@ out: 
	spin_lock_irqsave(&task->task_state_lock, flags);

	if (task->task_state_flags & SAS_TASK_STATE_ABORTED) {

		spin_unlock_irqrestore(&task->task_state_lock, flags);

		dev_info(dev, "slot complete: task(%p) aborted\n", task);

		dev_info(dev, "slot complete: task(%pK) aborted\n", task);

		return SAS_ABORTED_TASK;

	}

	task->task_state_flags |= SAS_TASK_STATE_DONE;
@@ -2466,7 +2466,7 @@ out: 
		spin_lock_irqsave(&device->done_lock, flags);

		if (test_bit(SAS_HA_FROZEN, &ha->state)) {

			spin_unlock_irqrestore(&device->done_lock, flags);

			dev_info(dev, "slot complete: task(%p) ignored\n",

			dev_info(dev, "slot complete: task(%pK) ignored\n",

				 task);

			return sts;

		}

drivers/scsi/hisi_sas/hisi_sas_v3_hw.c

+3 −3
Original line number Diff line number Diff line
@@ -2190,7 +2190,7 @@ slot_complete_v3_hw(struct hisi_hba *hisi_hba, struct hisi_sas_slot *slot) 


		slot_err_v3_hw(hisi_hba, task, slot);

		if (ts->stat != SAS_DATA_UNDERRUN)

			dev_info(dev, "erroneous completion iptt=%d task=%p dev id=%d CQ hdr: 0x%x 0x%x 0x%x 0x%x Error info: 0x%x 0x%x 0x%x 0x%x\n",

			dev_info(dev, "erroneous completion iptt=%d task=%pK dev id=%d CQ hdr: 0x%x 0x%x 0x%x 0x%x Error info: 0x%x 0x%x 0x%x 0x%x\n",

				 slot->idx, task, sas_dev->device_id,

				 dw0, dw1, complete_hdr->act, dw3,

				 error_info[0], error_info[1],
@@ -2245,7 +2245,7 @@ out: 
	spin_lock_irqsave(&task->task_state_lock, flags);

	if (task->task_state_flags & SAS_TASK_STATE_ABORTED) {

		spin_unlock_irqrestore(&task->task_state_lock, flags);

		dev_info(dev, "slot complete: task(%p) aborted\n", task);

		dev_info(dev, "slot complete: task(%pK) aborted\n", task);

		return SAS_ABORTED_TASK;

	}

	task->task_state_flags |= SAS_TASK_STATE_DONE;
@@ -2256,7 +2256,7 @@ out: 
		spin_lock_irqsave(&device->done_lock, flags);

		if (test_bit(SAS_HA_FROZEN, &ha->state)) {

			spin_unlock_irqrestore(&device->done_lock, flags);

			dev_info(dev, "slot complete: task(%p) ignored\n ",

			dev_info(dev, "slot complete: task(%pK) ignored\n ",

				 task);

			return sts;

		}

CRA Git | Maintained and supported by SUSTech CRA and CCSE