Commit e74d2ebd authored Nov 10, 2016 by Dexuan Cui Committed by Bjorn Helgaas Nov 16, 2016

PCI: hv: Delete the device earlier from hbus->children for hot-remove



After we send a PCI_EJECTION_COMPLETE message to the host, the host will
immediately send us a PCI_BUS_RELATIONS message with
relations->device_count == 0, so pci_devices_present_work(), running on
another thread, can find the being-ejected device, mark the
hpdev->reported_missing to true, and run list_move_tail()/list_del() for
the device -- this races hv_eject_device_work() -> list_del().

Move the list_del() in hv_eject_device_work() to an earlier place, i.e.,
before we send PCI_EJECTION_COMPLETE, so later the
pci_devices_present_work() can't see the device.

Signed-off-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Jake Oshins <jakeo@microsoft.com>
Acked-by: K. Y. Srinivasan <kys@microsoft.com>
CC: Haiyang Zhang <haiyangz@microsoft.com>
CC: Vitaly Kuznetsov <vkuznets@redhat.com>

parent 17978524

drivers/pci/host/pci-hyperv.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -1582,6 +1582,10 @@ static void hv_eject_device_work(struct work_struct *work)
		pci_dev_put(pdev);
		}

		spin_lock_irqsave(&hpdev->hbus->device_list_lock, flags);
		list_del(&hpdev->list_entry);
		spin_unlock_irqrestore(&hpdev->hbus->device_list_lock, flags);

		memset(&ctxt, 0, sizeof(ctxt));
		ejct_pkt = (struct pci_eject_response *)&ctxt.pkt.message;
		ejct_pkt->message_type.type = PCI_EJECTION_COMPLETE;
		@@ -1590,10 +1594,6 @@ static void hv_eject_device_work(struct work_struct *work)
		sizeof(*ejct_pkt), (unsigned long)&ctxt.pkt,
		VM_PKT_DATA_INBAND, 0);

		spin_lock_irqsave(&hpdev->hbus->device_list_lock, flags);
		list_del(&hpdev->list_entry);
		spin_unlock_irqrestore(&hpdev->hbus->device_list_lock, flags);

		put_pcichild(hpdev, hv_pcidev_ref_childlist);
		put_pcichild(hpdev, hv_pcidev_ref_pnp);
		put_hvpcibus(hpdev->hbus);

Admin message